Fix FP8 dequantization on MPS by falling back to CPU#34
Open
snwchd71 wants to merge 1 commit intoComfy-Org:mainfrom
Open
Fix FP8 dequantization on MPS by falling back to CPU#34snwchd71 wants to merge 1 commit intoComfy-Org:mainfrom
snwchd71 wants to merge 1 commit intoComfy-Org:mainfrom
Conversation
MPS (Apple Silicon) does not support FP8 dtype conversion, causing dequantize_per_tensor_fp8() to crash. Add an explicit device check with dtype guard to dequantize on CPU and transfer only the final result back to MPS. Includes a one-time logger.warning for visibility. Signed-off-by: spn <snwchd71@users.noreply.github.com>
636c256 to
2d427c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MPS (Apple Silicon) does not support FP8 dtype conversion, causing
dequantize_per_tensor_fp8()to crash with:This adds an explicit device + dtype guard to dequantize on CPU and transfer only the final result back to MPS. Includes a one-time
logger.warningfor visibility.torch.equalPrior work
stochastic_rounding,quant_ops.py). Both fixes are needed for end-to-end FP8 on MPS, confirmed by @vSnake87 on M3 Max.Test plan
test_dequantize_fp8_cpu_fallback_correctness— verifies fallback math is bit-identical to standard path (runs in CI, parametrized float16/bfloat16)test_dequantize_fp8_on_mps_device— end-to-end on actual MPS hardware (skipped in CI, parametrized float16/bfloat16)ruff checkclean