Skip to content

Update utils category to utilities#12498

Merged
alexisrolland merged 2 commits into
mainfrom
alexis/renamings
May 29, 2026
Merged

Update utils category to utilities#12498
alexisrolland merged 2 commits into
mainfrom
alexis/renamings

Conversation

@alexisrolland
Copy link
Copy Markdown
Member

@alexisrolland alexisrolland commented May 27, 2026

Summary

Update frontend only nodes categories to consolidate utility nodes into a utilities category (instead of utils). Paired with changes done in the core repo here: Comfy-Org/ComfyUI#14145

Changes

  • What:
    • Rename frontend only nodes category from utils to utilities
    • Move frontend only Primitive node from utils to utilities/primitive

Screenshots

image image

@alexisrolland alexisrolland requested a review from a team May 27, 2026 23:52
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 27, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

Four built-in node types have their UI category metadata renamed from utils to utilities (or utilities/primitive). Changes span node class definitions, a centralized system registry, and corresponding filter search tests.

Changes

Node category restructuring from utils to utilities

Layer / File(s) Summary
Node class category definitions
src/extensions/core/noteNode.ts, src/extensions/core/rerouteNode.ts, src/extensions/core/widgetInputs.ts
NoteNode, MarkdownNoteNode, and RerouteNode each change their static category property from utils to utilities. PrimitiveNode updates from utils to utilities/primitive for subcategory grouping.
System node definitions registry
src/stores/nodeDefStore.ts
The SYSTEM_NODE_DEFS object updates category assignments for PrimitiveNode, Reroute, Note, and MarkdownNote to align with the reorganized node class definitions.
Filter search test assertions
browser_tests/tests/nodeSearchBox.spec.ts
The "Removing from multiple filters" test suite updates expected chip text assertions to reflect the new utilities category value when filtering nodes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

size:S

Suggested reviewers

  • dante01yoon
  • pythongosssss

Poem

🐰 From utils to utilities bright,
Four nodes hop into new light,
Categories reorganized with care,
Tests now smile at changes fair!

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: renaming the utils category to utilities across frontend-only nodes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed PR is a renaming/refactoring (not a bug fix—title lacks fix/bugfix keywords), so E2E regression test coverage requirements do not apply per check instructions.
Adr Compliance For Entity/Litegraph Changes ✅ Passed ADR compliance check does not apply: no changed files under src/lib/litegraph/ or src/ecs/. Only extension and store metadata updates.
Description check ✅ Passed The pull request description comprehensively covers all required template sections with clear explanations of changes and supporting screenshots.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch alexis/renamings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 05/29/2026, 12:30:08 AM UTC

Links

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026

🎭 Playwright: ✅ 1652 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1633 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/extensions/core/noteNode.ts 0.00% 2 Missing ⚠️
src/extensions/core/rerouteNode.ts 0.00% 1 Missing ⚠️
src/extensions/core/widgetInputs.ts 0.00% 1 Missing ⚠️
@@             Coverage Diff             @@
##             main   #12498       +/-   ##
===========================================
- Coverage   74.95%   60.37%   -14.58%     
===========================================
  Files        1540     1426      -114     
  Lines       87311    73911    -13400     
  Branches    23852    20460     -3392     
===========================================
- Hits        65440    44623    -20817     
- Misses      21110    28788     +7678     
+ Partials      761      500      -261     
Flag Coverage Δ
e2e ?
unit 60.37% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/stores/nodeDefStore.ts 80.68% <ø> (-14.32%) ⬇️
src/extensions/core/rerouteNode.ts 0.00% <0.00%> (-58.13%) ⬇️
src/extensions/core/widgetInputs.ts 0.00% <0.00%> (-63.02%) ⬇️
src/extensions/core/noteNode.ts 0.00% <0.00%> (-72.42%) ⬇️

... and 1103 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexisrolland
Copy link
Copy Markdown
Member Author

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Not sure what I am supposed to do here, is this failing because of my changes or was it already failing? Is it blocking to merge?

Copy link
Copy Markdown
Collaborator

@AustinMroz AustinMroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what I am supposed to do here, is this failing because of my changes or was it already failing? Is it blocking to merge?

That message is stating that you changed lines of code, but did not write tests to verify that those changes are correct (and won't be broken by another person making changes 2 months from now)
That ci step will fail if you lack unit tests, but it will not block merging. I generally think any regression test is fine, but I'm not your PR since it has no tests.

If we wanna get really nitpicky?

  • Any custom nodes that places nodes in the utilities folder will not get moved. For instance, on cloud, the following custom nodes will be left in a vestigial utils folder:
    image
  • Your PR doesn't handle localization. There's already a nodeCategories.utils localzation that could have been updated to automatically move all backend nodes from utils to utilities that would be compatible with other languages. But
    • From my quick testing, it still leaves the frontend nodes you've changed in this PR behind. I think they'd need manual translation.
    • The PR to move core nodes has already been merged. I think we can just add a second localization key for nodeCategories.utilities so both get merged to the same localized name?

Mucky, but not something I'd block merging over.

@alexisrolland alexisrolland added this pull request to the merge queue May 29, 2026
Merged via the queue into main with commit dc1bc4c May 29, 2026
64 of 67 checks passed
@alexisrolland alexisrolland deleted the alexis/renamings branch May 29, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants