Update utils category to utilities#12498
Conversation
📝 WalkthroughWalkthroughFour built-in node types have their UI category metadata renamed from ChangesNode category restructuring from utils to utilities
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1652 passed, 0 failed · 3 flaky📊 Browser Reports
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #12498 +/- ##
===========================================
- Coverage 74.95% 60.37% -14.58%
===========================================
Files 1540 1426 -114
Lines 87311 73911 -13400
Branches 23852 20460 -3392
===========================================
- Hits 65440 44623 -20817
- Misses 21110 28788 +7678
+ Partials 761 500 -261
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1103 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Not sure what I am supposed to do here, is this failing because of my changes or was it already failing? Is it blocking to merge? |
AustinMroz
left a comment
There was a problem hiding this comment.
Not sure what I am supposed to do here, is this failing because of my changes or was it already failing? Is it blocking to merge?
That message is stating that you changed lines of code, but did not write tests to verify that those changes are correct (and won't be broken by another person making changes 2 months from now)
That ci step will fail if you lack unit tests, but it will not block merging. I generally think any regression test is fine, but I'm not your PR since it has no tests.
If we wanna get really nitpicky?
- Any custom nodes that places nodes in the utilities folder will not get moved. For instance, on cloud, the following custom nodes will be left in a vestigial utils folder:

- Your PR doesn't handle localization. There's already a
nodeCategories.utilslocalzation that could have been updated to automatically move all backend nodes fromutilstoutilitiesthat would be compatible with other languages. But- From my quick testing, it still leaves the frontend nodes you've changed in this PR behind. I think they'd need manual translation.
- The PR to move core nodes has already been merged. I think we can just add a second localization key for
nodeCategories.utilitiesso both get merged to the same localized name?
Mucky, but not something I'd block merging over.
Summary
Update frontend only nodes categories to consolidate utility nodes into a
utilitiescategory (instead of utils). Paired with changes done in the core repo here: Comfy-Org/ComfyUI#14145Changes
utilstoutilitiesutilstoutilities/primitiveScreenshots