[Partner Nodes] feat: add new nodes for Tripo3D P1 model#14155
Conversation
Signed-off-by: bigcat88 <bigcat88@icloud.com>
📝 WalkthroughWalkthroughThis PR adds three new Tripo P1 model generation nodes to ComfyUI: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
comfy_api_nodes/nodes_tripo.py (1)
989-1000: 💤 Low valueConsider tightening
face_limitvalidation to avoid API errors.The UI allows values from -1 to 20000, but the Tripo P1 API requires
face_limitto be either null (auto) or between 48-20000. Values 0-47 will pass the UI validation but fail at the API level with a less helpful error message.Consider either:
- Changing
min=48and using a separate boolean/combo for "auto" mode, or- Adding validation in
_build_p1_request_kwargsto raise a clear error for invalid ranges.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@comfy_api_nodes/nodes_tripo.py` around lines 989 - 1000, The UI currently allows face_limit values 0–47 which the Tripo P1 API rejects; update validation by either tightening the input in _p1_common_inputs to disallow 0–47 (set min=48 and keep a separate option for "auto"/-1) or add explicit validation in _build_p1_request_kwargs that maps -1 to None for auto and raises a clear, user-facing error if face_limit is between 0 and 47 (e.g., ValueError or a descriptive exception) before sending the request; reference the face_limit parameter and the functions _p1_common_inputs and _build_p1_request_kwargs when making the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@comfy_api_nodes/nodes_tripo.py`:
- Around line 989-1000: The UI currently allows face_limit values 0–47 which the
Tripo P1 API rejects; update validation by either tightening the input in
_p1_common_inputs to disallow 0–47 (set min=48 and keep a separate option for
"auto"/-1) or add explicit validation in _build_p1_request_kwargs that maps -1
to None for auto and raises a clear, user-facing error if face_limit is between
0 and 47 (e.g., ValueError or a descriptive exception) before sending the
request; reference the face_limit parameter and the functions _p1_common_inputs
and _build_p1_request_kwargs when making the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e449124e-b8e9-4bf1-878c-832126b8edc1
⛔ Files ignored due to path filters (1)
comfy_api_nodes/apis/tripo.pyis excluded by!comfy_api_nodes/apis/**
📒 Files selected for processing (1)
comfy_api_nodes/nodes_tripo.py
This PR adds three new nodes for the Tripo P1 model: https://platform.tripo3d.ai/docs/generation#p1-20260311
API Node PR Checklist
Scope
Pricing & Billing
If Need pricing update:
QA
Comms