Skip to content

[Partner Nodes] feat: add new nodes for Tripo3D P1 model#14155

Merged
alexisrolland merged 2 commits into
masterfrom
feat/api-nodes/Tripo3D-P1
May 29, 2026
Merged

[Partner Nodes] feat: add new nodes for Tripo3D P1 model#14155
alexisrolland merged 2 commits into
masterfrom
feat/api-nodes/Tripo3D-P1

Conversation

@bigcat88
Copy link
Copy Markdown
Contributor

@bigcat88 bigcat88 commented May 28, 2026

This PR adds three new nodes for the Tripo P1 model: https://platform.tripo3d.ai/docs/generation#p1-20260311

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

Signed-off-by: bigcat88 <bigcat88@icloud.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds three new Tripo P1 model generation nodes to ComfyUI: TripoP1TextToModelNode, TripoP1ImageToModelNode, and TripoP1MultiviewToModelNode. A suite of helper functions manages output_mode selection (mapping to texture and PBR request fields), builds common P1 request parameters, and handles task submission and polling. The extension's node registry is updated to expose the new nodes. Existing Tripo nodes receive formatting updates to their input schemas without functional changes.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 21.05% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding new nodes for the Tripo P1 model, which is the primary focus of the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description clearly relates to the changeset, detailing the addition of three new Tripo P1 nodes with API documentation reference and QA checklist completion.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
comfy_api_nodes/nodes_tripo.py (1)

989-1000: 💤 Low value

Consider tightening face_limit validation to avoid API errors.

The UI allows values from -1 to 20000, but the Tripo P1 API requires face_limit to be either null (auto) or between 48-20000. Values 0-47 will pass the UI validation but fail at the API level with a less helpful error message.

Consider either:

  1. Changing min=48 and using a separate boolean/combo for "auto" mode, or
  2. Adding validation in _build_p1_request_kwargs to raise a clear error for invalid ranges.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@comfy_api_nodes/nodes_tripo.py` around lines 989 - 1000, The UI currently
allows face_limit values 0–47 which the Tripo P1 API rejects; update validation
by either tightening the input in _p1_common_inputs to disallow 0–47 (set min=48
and keep a separate option for "auto"/-1) or add explicit validation in
_build_p1_request_kwargs that maps -1 to None for auto and raises a clear,
user-facing error if face_limit is between 0 and 47 (e.g., ValueError or a
descriptive exception) before sending the request; reference the face_limit
parameter and the functions _p1_common_inputs and _build_p1_request_kwargs when
making the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@comfy_api_nodes/nodes_tripo.py`:
- Around line 989-1000: The UI currently allows face_limit values 0–47 which the
Tripo P1 API rejects; update validation by either tightening the input in
_p1_common_inputs to disallow 0–47 (set min=48 and keep a separate option for
"auto"/-1) or add explicit validation in _build_p1_request_kwargs that maps -1
to None for auto and raises a clear, user-facing error if face_limit is between
0 and 47 (e.g., ValueError or a descriptive exception) before sending the
request; reference the face_limit parameter and the functions _p1_common_inputs
and _build_p1_request_kwargs when making the change.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e449124e-b8e9-4bf1-878c-832126b8edc1

📥 Commits

Reviewing files that changed from the base of the PR and between 4af9a47 and 45ebdb2.

⛔ Files ignored due to path filters (1)
  • comfy_api_nodes/apis/tripo.py is excluded by !comfy_api_nodes/apis/**
📒 Files selected for processing (1)
  • comfy_api_nodes/nodes_tripo.py

@alexisrolland alexisrolland merged commit ec1896a into master May 29, 2026
22 checks passed
@bigcat88 bigcat88 deleted the feat/api-nodes/Tripo3D-P1 branch May 29, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants