[Partner Nodes] fix: add runtime check for SeeDance2 image inputs#14152
Conversation
Signed-off-by: bigcat88 <bigcat88@icloud.com>
📝 WalkthroughWalkthroughThis PR adds input validation and downscaling for Seedance image processing in two ByteDance nodes. It imports a downscaling utility, introduces a 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@comfy_api_nodes/nodes_bytedance.py`:
- Around line 1793-1797: The synchronous call to _prepare_seedance_image inside
the async def execute is blocking the event loop; change those direct calls (the
ones for first_frame and last_frame and the per-key calls against
reference_images[key]) to run in a threadpool by awaiting
asyncio.to_thread(_prepare_seedance_image, ...) or using loop.run_in_executor,
and for multiple reference images use asyncio.gather over to_thread tasks so all
image preparations run off the event loop; update the execute function to await
these offloaded tasks where first_frame, last_frame and reference_images are
assigned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1e0040cd-7c12-4dfd-8561-ff888694fc1f
📒 Files selected for processing (1)
comfy_api_nodes/nodes_bytedance.py
…mfy-Org#14152) Signed-off-by: bigcat88 <bigcat88@icloud.com>
PR adds runtime input validation for the Seedance 2.0 first-last-frame and reference nodes - so users no longer hit opaque server-side InvalidParameter errors at upload.
ReferenceNode's existing
auto_downscalewidget continues to control reference-video downscaling only and now defaults toTrueAPI Node PR Checklist
Scope
Pricing & Billing
If Need pricing update:
QA
Comms