Support context window for PiD and fix lq_latent rounding#14136
Merged
Conversation
how did you get here...
not worth it
|
Caution Review failedAn error occurred during the review process. Please try again later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Context windows are a way to handle the aspect ratio limitations of the model, also noticed mismatch with some dimensions due to rounding differences, so two fixes:
Context window slicing needed to account for the lq_latent scaling
PiD upscaling failed with a tensor size mismatch when the output width or height wasn't a multiple of 16. The two halves of the model rounded the size differently, so they ended up one row/column apart and couldn't be combined.
Also in this situation almost halves peak VRAM use:
Context window settings (easier to use node specific to this model can be added later):