Skip to content

Remove some useless annotations imports.#14105

Merged
comfyanonymous merged 1 commit into
masterfrom
temp_pr
May 26, 2026
Merged

Remove some useless annotations imports.#14105
comfyanonymous merged 1 commit into
masterfrom
temp_pr

Conversation

@comfyanonymous
Copy link
Copy Markdown
Member

@comfyanonymous comfyanonymous commented May 26, 2026

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7cd63dc3-ec2d-4898-a6d0-a54c0a75a73f

📥 Commits

Reviewing files that changed from the base of the PR and between 50643c3 and 374db77.

⛔ Files ignored due to path filters (3)
  • comfy_api_nodes/apis/__init__.py is excluded by !comfy_api_nodes/apis/**
  • comfy_api_nodes/apis/bfl.py is excluded by !comfy_api_nodes/apis/**
  • comfy_api_nodes/apis/stability.py is excluded by !comfy_api_nodes/apis/**
📒 Files selected for processing (39)
  • app/assets/services/metadata_extract.py
  • app/custom_node_manager.py
  • app/frontend_management.py
  • app/model_manager.py
  • app/user_manager.py
  • comfy/comfy_types/node_typing.py
  • comfy/ldm/lightricks/vae/causal_audio_autoencoder.py
  • comfy/ldm/lightricks/vae/causal_video_autoencoder.py
  • comfy/ldm/lumina/model.py
  • comfy/ldm/moge/geometry.py
  • comfy/ldm/moge/model.py
  • comfy/ldm/moge/modules.py
  • comfy/ldm/moge/panorama.py
  • comfy/lora.py
  • comfy/patcher_extension.py
  • comfy/sd.py
  • comfy_api/latest/__init__.py
  • comfy_api/latest/_input_impl/video_types.py
  • comfy_api/latest/_util/video_types.py
  • comfy_execution/graph.py
  • comfy_execution/progress.py
  • comfy_execution/validation.py
  • comfy_extras/mediapipe/face_geometry.py
  • comfy_extras/mediapipe/face_landmarker.py
  • comfy_extras/nodes_audio.py
  • comfy_extras/nodes_context_windows.py
  • comfy_extras/nodes_curve.py
  • comfy_extras/nodes_images.py
  • comfy_extras/nodes_logic.py
  • comfy_extras/nodes_math.py
  • comfy_extras/nodes_mediapipe.py
  • comfy_extras/nodes_moge.py
  • comfy_extras/nodes_number_convert.py
  • comfy_extras/nodes_painter.py
  • comfy_extras/nodes_resolution.py
  • comfy_extras/nodes_toolkit.py
  • comfy_extras/nodes_video.py
  • folder_paths.py
  • nodes.py
💤 Files with no reviewable changes (39)
  • comfy_extras/nodes_painter.py
  • comfy/ldm/lumina/model.py
  • app/custom_node_manager.py
  • app/model_manager.py
  • comfy_execution/progress.py
  • comfy/ldm/lightricks/vae/causal_video_autoencoder.py
  • comfy_extras/nodes_mediapipe.py
  • app/user_manager.py
  • comfy/ldm/moge/modules.py
  • comfy_extras/nodes_number_convert.py
  • comfy_execution/graph.py
  • comfy_extras/nodes_logic.py
  • comfy_extras/nodes_toolkit.py
  • comfy_extras/nodes_math.py
  • comfy_extras/nodes_resolution.py
  • folder_paths.py
  • comfy/sd.py
  • app/assets/services/metadata_extract.py
  • comfy_extras/nodes_context_windows.py
  • comfy_api/latest/_input_impl/video_types.py
  • comfy/patcher_extension.py
  • comfy_extras/nodes_video.py
  • comfy/ldm/moge/model.py
  • comfy/ldm/moge/panorama.py
  • comfy_api/latest/init.py
  • nodes.py
  • comfy_extras/nodes_audio.py
  • comfy/ldm/moge/geometry.py
  • comfy_extras/nodes_images.py
  • comfy_api/latest/_util/video_types.py
  • comfy_extras/mediapipe/face_landmarker.py
  • comfy_extras/nodes_curve.py
  • comfy_extras/mediapipe/face_geometry.py
  • comfy_extras/nodes_moge.py
  • comfy/lora.py
  • comfy/comfy_types/node_typing.py
  • comfy/ldm/lightricks/vae/causal_audio_autoencoder.py
  • app/frontend_management.py
  • comfy_execution/validation.py

📝 Walkthrough

Walkthrough

This pull request removes the from __future__ import annotations directive from 35 Python modules across the codebase, reverting type annotation evaluation behavior from postponed (deferred as strings per PEP 563) to eager evaluation at runtime. The affected modules span application layer (app/), core inference engine (comfy/), API bindings (comfy_api/), execution framework (comfy_execution/), and node implementations (comfy_extras/). Additionally, the face_geometry module docstring is enhanced to document its weighted Procrustes solver implementation that computes 4x4 facial transformation matrices.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains a PR checklist template but does not describe the actual changes made in the pull request. Replace the generic checklist with a brief explanation of why these annotations imports are being removed and their impact.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing from __future__ import annotations imports across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@comfyanonymous comfyanonymous merged commit da49b7d into master May 26, 2026
17 checks passed
@comfyanonymous comfyanonymous deleted the temp_pr branch May 26, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant