feat: Integrate bpmnlint#87
Conversation
Surface model validation issues directly in rendered diagrams and in the editor via bpmn-js-bpmnlint. A toggle button on the canvas shows clickable error/warning overlays on the offending elements. - New `lint` attribute on <bpmnio>: on | off | inactive. The viewer defaults to button-present-inactive; the editor defaults to active. - Rules live in .bpmnlintrc (extends bpmnlint:recommended) and are packed into the committed bundles at build time via bpmnlint-pack-config, since bpmnlint cannot resolve rules in the browser. build:vendor handles this automatically. - The lint module runs in a plain Viewer (every injected service is present; editorActions resolves optionally), so no viewer upgrade was needed. - Add syntax tests for the lint attribute; default output is unchanged when the attribute is absent. Refs #83
888a256 to
13f0108
Compare
alibama
left a comment
There was a problem hiding this comment.
seems reasonable - my code review isn't worth the keystrokes here, but i'll acknowledge reading it and 👍 fwiw?
looks like internationalizing this for new languages won't be much work?
|
Yes indeed translation is a perfect job for LLMs |
13f0108 to
4ca108f
Compare
4ca108f to
738a44f
Compare
|
Thanks for your contribution! I shipped the slightly reworked state. I hope others will enjoy. Likely there will be follow ups but I prefer always not going ahead of what people need, often the risk is to miss the point. Here the changes where mostly to keep the previous behavior by default to not upset people when they update the plugin. This is also a principle I try to follow when possible. |
Fixes #83
Surface model validation issues directly in rendered diagrams and in the editor via bpmn-js-bpmnlint. A toggle button on the canvas shows clickable error/warning overlays on the offending elements.