docs: add experiment run guide, citation, and badges#63
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughThis PR adds citation metadata and comprehensively rewrites the README to guide users through experiment replication. A new CITATION.cff file provides structured citation information. The README now documents prerequisites, installation, environment configuration, a validation run, full experiment matrix execution, analysis, and dashboard access, plus reproducibility tracking via environment snapshots. Local development instructions are expanded with test and format commands. ChangesDocumentation and Citation Setup
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile`:
- Line 10: Create and switch to a non-root user in the Dockerfile before running
mmdc/Chromium: add a dedicated unprivileged user (e.g., with useradd/groupadd or
adduser), set HOME, chown/chmod any directories or files that the app or
Chromium needs (cache, /tmp, .config, mmdc output dirs), and add a USER
directive so mmdc/Chromium runs as that user instead of root; ensure any install
steps that require root remain before the USER switch and that the runtime
invocation of mmdc/Chromium uses the non-root user to remove --no-sandbox
exposure.
- Line 10: Replace the mutable base image tag in the FROM line (currently "FROM
python:3.11-slim") with a digest-pinned image (e.g.,
"python:3.11-slim@sha256:<digest>") or otherwise resolve and lock the exact
image digest to ensure immutability; in the apt-get install block pin each
system package to a specific version or switch the APT source to a dated
snapshot (or use apt-get install package=version for each package) and add
apt-get update && apt-get install with explicit package versions and apt-get
clean steps so package versions are reproducible; keep the existing mermaid-cli
pin (mermaid-cli@11.4.2) as-is.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 679208cd-128e-40eb-a023-3b62700ae200
📒 Files selected for processing (8)
CITATION.cffDockerfileREADME.mddocker-compose.ymlout/.gitkeepsrc/maestro/analysis/metrics.pysrc/maestro/experiment_config.pysrc/maestro/viz/mermaid_render.py
0771ffe to
f40830f
Compare
Lead with 'Running the experiment' (prereqs → install → validate → run → analyse → dashboard, local and Docker commands) and a reproducibility audit-trail note pointing at run_environments. Phrase it as producing results (v1.0.0 ships without data; replication framing follows in v1.0.1). Demote tests to a 'Local development' section (macOS-tested) and note Docker as the platform-independent route. Link each provider's API docs for key setup. Add honest status badges (License, Python, Ruff, pre-commit) and a CITATION.cff for the thesis artifact (DOI and release date left commented out.)
f40830f to
b924d4f
Compare
Here's the PR description for the doc branch, as clean copy-paste markdown:
Summary
Documentation pass toward v1.0.0, addressing the reviewer's replicability recommendation (Empfehlung #1). Adds a high-level "Running the experiment" guide to the README, honest status badges, and a
CITATION.cfffor the thesis artifact. Closes #26.Phrased for v1.0.0, which ships without results — the guide describes how to produce results, not reproduce them. The replication framing (re-running against published numbers) follows in v1.0.1 once the experiment data and polished viz land.
What changed
README
run_environmentstable (per-run OS, arch, Python, library versions, git commit, image digest), which is what makes future replication diagnosable.Badges
CITATION.cff
doianddate-releasedare left commented out.Scope
Verification
maestro.run,maestro.analysis,viz/app.py;--strategy/--tier/--repeatsare real flags).LICENSE,CITATION.cff,.env.template,.pre-commit-config.yaml).CITATION.cffvalidates as well-formed CFF with all required keys.Summary by CodeRabbit