Open
Conversation
| @@ -397,7 +406,8 @@ def get_braket_device(device: AWSDevice, is_noisy: bool = False) -> "BraketDevic | |||
Collaborator
There was a problem hiding this comment.
pkg_resources is deprecated on python 3.12 and onwards, might have to change this line.
…p into fix-braket-ahs-devices
Comment on lines
+407
to
+410
| try: | ||
| mpqp_version = version("mpqp") | ||
| except PackageNotFoundError: | ||
| mpqp_version = "0.0.0+unknown" |
Contributor
There was a problem hiding this comment.
maybe now even use your fresh new feature mpqp.__version__ ?
| return Result( | ||
| job, | ||
| data=None, | ||
| errors="Unsupported Braket backend for QCircuit (see warning).", |
Contributor
There was a problem hiding this comment.
error isn't meant for a user error, but rather for the statistical error of the device I believe, I wouldn't mix the two
| data: float | dict["str", float] | StateVector | list[Sample], | ||
| errors: Optional[float | dict[Any, Any]] = None, | ||
| data: float | dict["str", float] | StateVector | list[Sample] | None, | ||
| errors: Optional[float | dict[Any, Any] | str] = None, |
| is_noisy: bool = False, | ||
| is_gate_model: bool = True, | ||
| ) -> "BraketDevice": | ||
| """Returns the AwsDevice device associate with the AWSDevice in parameter. |
Henri-ColibrITD
requested changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.