Skip to content

Add jQuery dependency to script#2

Open
fishy15 wants to merge 2 commits into
Coki628:masterfrom
fishy15:master
Open

Add jQuery dependency to script#2
fishy15 wants to merge 2 commits into
Coki628:masterfrom
fishy15:master

Conversation

@fishy15
Copy link
Copy Markdown

@fishy15 fishy15 commented Jan 29, 2023

No description provided.

@Coki628
Copy link
Copy Markdown
Owner

Coki628 commented Jan 30, 2023

Hello, fishy15
Thanks for the PR

May I know why you want to add these dependencies to the script?
It works without them on my browser

@fishy15
Copy link
Copy Markdown
Author

fishy15 commented Jan 30, 2023

I am using Firefox 109.0 on macOS 13.1. The scripts used to work, but they stopped working maybe a few months ago since it was unable to use the $ and tablesorter variables otherwise. Without those dependencies, I get the following error:

jQuery error

Similarly, if I only include jQuery, then the tablesorter function is not defined. I am not sure why the script is unable to use the libraries on Codeforces itself though.

@Coki628
Copy link
Copy Markdown
Owner

Coki628 commented Jan 30, 2023

hmm, I see
I'm using Chrome and Tampermonkey

I would want to apply your change, but another diffrent error occurred when I tried applying it on my local
It sais some function is not found, I think this jquery and tablesorter has overridden the original ones on Codeforces (that's maybe the version is different)

I think Codeforces is still using jquery and related libraries
$ should be able to use
Let me try to find a better solution

Maybe we shouldn't override the libraries on the original site
Otherwise, might want to adjust it to the same version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants