-
Notifications
You must be signed in to change notification settings - Fork 0
feat: integrate reference product workload contract #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
.planning/phases/02-reference-product-integration/02-01-PLAN.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Phase 2 Plan: Reference Product Integration | ||
|
|
||
| ## Goal | ||
|
|
||
| Implement the public `cas-reference-product` deployment interface without | ||
| deploying Azure resources or assuming a landing-zone topology. | ||
|
|
||
| ## Tasks | ||
|
|
||
| 1. Inject the required non-secret workload configuration from Bicep. | ||
| 2. Configure port 8080, internal ingress, system-assigned identity, and health | ||
| probes matching the public workload interface. | ||
| 3. Add optional Foundry RBAC gated by explicit project resource and role | ||
| definition resource IDs, scoped only to that project. | ||
| 4. Add contract tests and documentation covering the integration boundary. | ||
| 5. Build all Bicep and parameter files, run Pester, and retain non-deploying | ||
| what-if behavior. | ||
|
|
||
| ## Guardrails | ||
|
|
||
| - Do not deploy Azure resources. | ||
| - Do not add private networking or Azure Policy without a target landing-zone | ||
| contract. | ||
| - Do not select a broad built-in role on the operator's behalf. |
12 changes: 12 additions & 0 deletions
12
.planning/phases/02-reference-product-integration/02-01-SUMMARY.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # Phase 2 Summary: Reference Product Integration | ||
|
|
||
| Implemented the reference product configuration and health contract in the | ||
| Container App module. Application Insights configuration flows directly from | ||
| the observability module. Foundry role assignment is disabled by default and | ||
| can only be enabled with both an explicit Foundry project resource ID and an | ||
| explicit approved role definition resource ID; its scope is the project. | ||
|
|
||
| Private networking and Azure Policy were reviewed but not added because no | ||
| landing-zone topology, DNS, egress, or policy ownership contract exists. | ||
|
|
||
| No Azure resources were deployed. |
18 changes: 18 additions & 0 deletions
18
.planning/phases/02-reference-product-integration/02-VERIFICATION.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Phase 2 Verification | ||
|
|
||
| **Status:** Passed locally | ||
|
|
||
| ## Evidence | ||
|
|
||
| - `az bicep build --file infra/main.bicep --stdout`: passed. | ||
| - All dev, test, and prod Bicep parameter builds: passed. | ||
| - `scripts/validate.ps1`: passed. | ||
| - Pester infrastructure contract tests: 10 passed, 0 failed. | ||
| - `scripts/what-if.ps1 -Environment dev -Location northeurope`: succeeded | ||
| with only expected creates and no deployment. The preview proved internal | ||
| ingress, port 8080, system-assigned identity, required environment settings, | ||
| both health probes, and no default Foundry role assignment. | ||
| - Tests prove required environment injection, probes, port 8080, internal | ||
| ingress default, system-assigned identity, principal output, optional RBAC | ||
| gating, project scope, and non-deploying what-if commands. | ||
| - No Azure resources deployed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an operator selects
workflowBackend = 'foundry'but leaves either Foundry endpoint or agent name empty, the template still validates and deploys because both required application inputs default to empty strings without any cross-parameter assertion. The resulting Container App receives an invalid Foundry configuration and, according to the documented readiness contract, cannot become ready; reject this combination before deployment rather than allowing an unusable revision.Useful? React with 👍 / 👎.