🔧 chore(security): pin Go toolchain to 1.26.4 as CI's single source of truth#22
Merged
Conversation
…f truth go.mod declared only `go 1.26.0` (no toolchain directive), so builds and scans floated to whatever 1.26.x a runner installed, and a clean-machine build on 1.26.0 would ship reachable crypto/x509 + net/url CVEs (GO-2026-4599/4600/4601, fixed in 1.26.1). - 🔧 go.mod: add `toolchain go1.26.4` — a floor for every build via GOTOOLCHAIN=auto. - 🔄 all 9 workflows: setup-go `go-version: "1.26"` -> `go-version-file: go.mod` (14 steps), so the pinned toolchain governs build, govulncheck, Grype, and release in lockstep. setup-go honors the toolchain directive over the go line. - 📝 CHANGELOG: document the pin and the one-source-of-truth switch. Verified: go build ./... and govulncheck ./... clean on 1.26.4; actionlint + zizmor clean across all workflows.
scttbnsn
requested review from
ALARGECOMPANY and
biggest-littlest
as code owners
biggest-littlest
approved these changes
Jun 16, 2026
biggest-littlest
left a comment
biggest-littlest
left a comment
Member
There was a problem hiding this comment.
LGTM — toolchain pinned to 1.26.4, go-version-file everywhere. govulncheck clean on 1.26.4.
ALARGECOMPANY
approved these changes
Jun 16, 2026
ALARGECOMPANY
left a comment
ALARGECOMPANY
left a comment
Member
There was a problem hiding this comment.
Approved. One source of truth for the Go version is the right call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the Grype/govulncheck consolidation.
go.moddeclared onlygo 1.26.0with notoolchaindirective, so builds and scans floated to whatever 1.26.x a runner installed — and a build on a clean 1.26.0 machine would ship the reachablecrypto/x509+net/urladvisories (GO-2026-4599/4600/4601, fixed in 1.26.1). That's also exactly why the firstgo-version-fileattempt failed earlier.toolchain go1.26.4— a floor enforced everywhere viaGOTOOLCHAIN=auto.setup-gogo-version: "1.26"→go-version-file: go.mod(14 steps).setup-gohonors the toolchain directive over thegoline, so the pin now governs build, govulncheck, Grype, and release in lockstep — bump it in one place.Verified locally:
go build ./...andgovulncheck ./...clean on 1.26.4; actionlint + zizmor clean across all workflows.