🐛 fix(edge): order exec input and add outbound backpressure to the tunnel#20
Merged
Conversation
…nnel - 🐛 fix(edge): register exec sessions synchronously and buffer early input in arrival order via a single per-session writer goroutine, so keystrokes typed before the Docker exec is live are replayed in order instead of dropped - 🐛 fix(edge): front all outbound writes with a single sendPump goroutine over a bounded queue with a per-frame write deadline; evict (and reconnect) a controller that can't keep up instead of head-of-line-blocking every session, stalling the read pump, or hanging the agent indefinitely - 🔄 refactor(edge): add a consumer-side dockerAPI seam so exec and request fan-out are testable against a scripted fake daemon with no live socket - 🧪 test(edge): add a dedicated tunnel test harness (in-memory WS pair, scripted fakeConn/fakeDocker) covering hello signing, request dispatch/backpressure, exec-session lifecycle, ordered input replay, and send-path eviction
All three sub-items (ordered exec I/O, outbound backpressure, dedicated test harness) have landed, so flip the roadmap line to shipped and record the two fixes plus the harness under [Unreleased].
scttbnsn
requested review from
ALARGECOMPANY and
biggest-littlest
as code owners
biggest-littlest
approved these changes
Jun 16, 2026
biggest-littlest
left a comment
biggest-littlest
left a comment
Member
There was a problem hiding this comment.
LGTM — exec input ordering + outbound backpressure on the tunnel reads correctly.
ALARGECOMPANY
approved these changes
Jun 16, 2026
ALARGECOMPANY
left a comment
ALARGECOMPANY
left a comment
Member
There was a problem hiding this comment.
Approved. Edge robustness fix is sound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edge tunnel robustness fixes (SPEC §13).
Branch was committed locally in a prior session; pushing + PRing so it isn't lost. CI validates on this PR.