feat(help): add mentor assignment email notification#202
Conversation
|
@asthasinghcs is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@asthasinghcs Your tests are failing please revisit it and pass all the checks please |
|
hey @asthasinghcs, thanks for picking this up. ran through the diff and there are a few blockers that'll stop this from working end-to-end. flagging them so you can fix in one pass. 1. 2.
go with whichever fits the broader plan, but the column path is simpler if profiles already mirror auth identity. 3. unescaped user input in the email HTML. 4. test coverage is thin.
once 1 and 2 are sorted the feature will actually run. happy to look again once you push. |
|
hi @Piyush-Thakkarr and @Soumya-codr apologies for the delay, i will fix the issues right away! |
|
@Piyush-Thakkarr Thanks for the review. You're right, I checked the schema and Before I update the implementation, could you confirm the preferred source for mentor emails?
I'll update the implementation accordingly and address the escaping/tests feedback in the same pass. |
|
CI failing, can you please fix it |
|
@Piyush-Thakkarr @Ayush-Patel-56 CI issue has been addressed by adding the missing Regarding the review feedback, I verified that Before making schema/auth changes, could you please confirm the preferred source for mentor emails?
I'd like to align with the intended architecture and address the remaining review feedback in the same update. |
Summary
RESEND_API_KEYto.env.exampleTesting
Closes #54