[ISSUE #950] Code quality enhancement - Project Presenter#1011
Open
codeclara42 wants to merge 2 commits intomasterfrom
Open
[ISSUE #950] Code quality enhancement - Project Presenter#1011codeclara42 wants to merge 2 commits intomasterfrom
codeclara42 wants to merge 2 commits intomasterfrom
Conversation
HeitorMC
requested changes
Aug 11, 2025
| project_users: project_users_path(self), | ||
| project_settings: edit_project_path(self), | ||
| project_join: join_project_path(self), | ||
| project_unjoin: "#{project_users_path(self)}/" |
Member
There was a problem hiding this comment.
Why is project_unjoin using string interpolation here? I think the interpolation and trailing / could be added in ProjectCard.jsx, where the full path is built.
Author
There was a problem hiding this comment.
on this specific route it ended with "/" on the .spec file (the project presenter one)
not sure why
Author
There was a problem hiding this comment.
checking the original spec/presenters/project_presenter_spec.rb before changes, you can see this specific route is the only one with a "/" on the end, the other ones don't have that. I mantained the original route, keeping it with "/" on the end in all files (including .rb files)
codeclara42
added
ruby
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR do ?
This pull request aims to address the issues reported on #950
Related Issues
issue #950
Screenshots (if applicable)
Additional Notes (if any)
Firstly, I'm tackling the camelCase issue. Then I'll check if it's worth it to remove the hardcoded routes