WM | ITP-JAN-25 | HATEF_EIDI | Module-Data-Groups | Sprint 3| Todo List #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HatefEidi
requested review from
ellietms and
halilibrahimcelik
and removed request for
halilibrahimcelik
HatefEidi
added
🎯 Topic Problem-Solving
📅 Sprint 3
halilibrahimcelik
added
Review in progress
| // Function to create list items | ||
| function createListItem(todo, index, isCompleted) { | ||
| const listItem = document.createElement("li"); | ||
| listItem.className = 'todo-item'; |
There was a problem hiding this comment.
like I said in reading-list project, please define your constants at the beginning of your script not inside of your functions.
| // Creating the complete/uncomplete button | ||
| const completeButton = document.createElement("button"); | ||
| completeButton.textContent = isCompleted ? 'Uncomplete ❌' : 'Complete ✔️'; | ||
| completeButton.onclick = () => toggleComplete(index, isCompleted); |
There was a problem hiding this comment.
Good way to use ternary operator
| populateTodoList(); | ||
| createParagraph(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Smooth way of handling toggle, and I also like the way you destructure object
halilibrahimcelik
approved these changes
Mar 22, 2025
halilibrahimcelik
left a comment
halilibrahimcelik
left a comment
There was a problem hiding this comment.
Well done everything seems to be okay, you can close this PR.
HatefEidi
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
creating task, adding completed label to the tasks, and deleting all the completed tasks together.
Questions
Ask any questions you have for your reviewer.