Skip to content

Karla Grajales | Sprint-2 - Module-Data-Groups | SPRINT 2 #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Grajales-K wants to merge 12 commits into from
Closed

Karla Grajales | Sprint-2 - Module-Data-Groups | SPRINT 2 #291

Grajales-K wants to merge 12 commits into from

Conversation

@Grajales-K
Copy link

@Grajales-K Grajales-K commented Jan 16, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

I learnt how to manipulate strings and objects in JavaScript, including counting word occurrences, swapping object keys and values, and fixing function logic.

Questions

Ask any questions you have for your reviewer.

@Grajales-K Grajales-K added 🏕 Priority Mandatory This work is expected 🔑 Priority Key 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 16, 2025
@Grajales-K Grajales-K requested review from CE-0 and halilibrahimcelik and removed request for CE-0 January 16, 2025 05:35
@halilibrahimcelik halilibrahimcelik added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 16, 2025
halilibrahimcelik
halilibrahimcelik reviewed Jan 16, 2025
View reviewed changes
halilibrahimcelik
halilibrahimcelik reviewed Jan 16, 2025
View reviewed changes
@Grajales-K Grajales-K added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 16, 2025
@Grajales-K Grajales-K removed the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jan 16, 2025
halilibrahimcelik
halilibrahimcelik reviewed Jan 16, 2025
View reviewed changes
Copy link

@halilibrahimcelik halilibrahimcelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, all tests have been passed and you met all the criteria stated in the readme file.

@halilibrahimcelik halilibrahimcelik added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 16, 2025
@Grajales-K Grajales-K added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Jan 16, 2025
@Grajales-K
Copy link
Author

Grajales-K commented Jan 17, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CE-0 CE-0 Awaiting requested review from CE-0

1 more reviewer

@halilibrahimcelik halilibrahimcelik halilibrahimcelik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 🏕 Priority Mandatory This work is expected Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Grajales-K @halilibrahimcelik @illicitonion @SpectacularLandscape