-
Notifications
You must be signed in to change notification settings - Fork 2
Bump the all-dependencies group across 1 directory with 38 updates #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
3
commits into
main
Choose a base branch
from
dependabot/npm_and_yarn/all-dependencies-71db446c95
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| **Incomplete / Missing Prisma v7 Upgrade Items (Repo-Specific)** | ||
| - Generator not migrated: prisma/schema.prisma still uses `provider = "prisma-client-js"`; Prisma v7 deprecates this and expects `provider = "prisma-client"` with a required `output` path (import paths will change). | ||
| - Dev workflow drift: Prisma v7 no longer auto-runs `prisma generate` or seeding on `migrate dev/reset`, but package.json scripts (`prisma:migrate:dev`, `prisma:reset`) don’t compensate—easy to end up with stale client + unseeded DB. | ||
| - Config duplication risk: schema/seed configuration exists in 3 places (prisma.config.ts, package.json `"prisma"` block, and many scripts passing `--schema=...`). This can drift over time. | ||
| - SSL warning root cause: docs/examples (and likely your real `DATABASE_URL`) use `?sslmode=require` (seen in .env.example, .env.production.example, and multiple docs). With your chosen posture (“strict verification”), you should pin `sslmode=verify-full` explicitly to preserve behavior and silence the warning. | ||
| - Security hygiene gap (best practice): repo contains committed env files with real-looking DB/API tokens (.env, .env.example). Even if “demo”, treat as potentially sensitive and rotate/remove from git. | ||
|
|
||
| ## Plan: Prisma v7 Upgrade Completion + SSLmode Warning | ||
|
|
||
| TL;DR: Stabilize day-to-day dev/prod workflows first (explicit generate + seed + SSL verify-full), then later do the larger generator migration (`prisma-client-js` → `prisma-client`) since you selected “Later”. Also reduce config duplication so Prisma v7 behavior is predictable across scripts and CI. | ||
|
|
||
| **Steps** | ||
| 1. Fix SSL warning + align with strict verification | ||
| - Update your actual `DATABASE_URL` (where build reads it, typically `.env.local` or your CI env) from `sslmode=require` to `sslmode=verify-full`. | ||
| - Update examples/docs that currently say `sslmode=require` (at minimum: .env.example, .env.production.example, and scripts that print guidance like scripts/seed-production.js). | ||
| - If `verify-full` fails (cert/hostname/CA issues), decide whether to add CA via connection-string `sslrootcert` (or equivalent) vs relaxing verification (not recommended given your chosen posture). | ||
|
|
||
| 2. Make Prisma v7 dev scripts explicit (generate + seed) | ||
| - Adjust package.json scripts so `prisma:migrate:dev` explicitly runs `prisma generate` after migrations. | ||
| - Add a dedicated script that restores the old “auto-seed” ergonomics, e.g. a `prisma:migrate:dev:seed` / `db:reset:seed` flow that runs `prisma db seed` (or your existing `npm run prisma:seed`) after `migrate dev/reset`. | ||
|
|
||
| 3. Reduce Prisma config drift (pick one source of truth) | ||
| - Prefer Prisma v7 config file as the canonical schema location (prisma.config.ts). | ||
| - Then either (a) remove the `"prisma": { schema, seed }` block from package.json, or (b) keep it but stop duplicating `--schema=...` everywhere—choose one consistent pattern. | ||
|
|
||
| 4. Generator migration (deferred, but planned) | ||
| - Update prisma/schema.prisma generator to `provider = "prisma-client"` and add required `output`. | ||
| - Update imports across runtime + scripts (e.g., src/lib/prisma.ts, prisma/seed.mjs) to import Prisma Client/types from the new generated output path. | ||
| - Verify build tooling + deployment packaging includes the generated client output directory. | ||
|
|
||
| 5. Security cleanup (recommended follow-up) | ||
| - Remove committed secrets from .env and sanitize .env.example to placeholders; rotate any credentials that were real. | ||
|
|
||
| **Verification** | ||
| - Run `npm run build` and confirm the SSL warning is gone. | ||
| - Run `npm run prisma:migrate:dev` and confirm Prisma Client is regenerated afterward. | ||
| - Run your new explicit seed flow and confirm the app boots with expected demo data. | ||
| - For prod-like verification: run `npm run prisma:migrate:deploy` + seed as needed in a staging DB. | ||
|
|
||
| **Decisions** | ||
| - Decision: Generator migration deferred (per your selection), but plan includes a clean, bounded follow-up phase. | ||
| - Decision: SSL strict verification applies to prod/staging; local dev can remain non-strict if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lint snapshot reports
exitCode: 1(and an eslint error inrawOutput), which suggests the PR is not lint-clean. TherawOutputalso references issues (e.g. unusedreq, unusedsession/router) that no longer match the current diffs. Please re-run the lint collection step (or regenerate this file) after final code changes so it reflects the current state.