Skip to content

Comments

Fixed missing Langs#52

Merged
The-Code-Monkey merged 1 commit into1.21from
Lang
Feb 22, 2026
Merged

Fixed missing Langs#52
The-Code-Monkey merged 1 commit into1.21from
Lang

Conversation

@AnyaPizza
Copy link
Collaborator

@AnyaPizza AnyaPizza commented Feb 22, 2026

Summary by CodeRabbit

Release Notes

  • New Features

    • Added support for new ore variants (Copper, Onyxium, Thorium, Adamantite, Mithril, Cobalt, Iron, Gold, Silver) across multiple stone types including basalt, volcanic, shale, sandstone, and slate.
  • Removals

    • Removed support for certain log block variants.

@AnyaPizza AnyaPizza self-assigned this Feb 22, 2026
@AnyaPizza AnyaPizza added the bug Something isn't working label Feb 22, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 22, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

This PR updates the language provider to remove translations for several log block types and add comprehensive translations for ore variants across multiple stone types (basalt, volcanic, shale, stone, sandstone, slate, etc.) and ore materials (copper, onyxium, thorium, adamantite, mithril, cobalt, iron, gold, silver). Item translations for ore variants are also added. No public method signatures or class structure changes.

Changes

Cohort / File(s) Summary
Translation Data Updates
src/client/java/com/tcm/MineTale/datagen/ModLangProvider.java
Removed translations for ash, aspen, azure, cedar, crystalwood, dry, and blue_fig logs plus Petrified Log. Added 54 lines of translations for ore block and item variants across multiple stone types and ore materials.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • The-Code-Monkey

Poem

🐰 Logs once grand now fade away,
Ores in stone begin their day,
Copper gleams through basalt deep,
Thorium's secrets we shall keep!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fixed missing Langs' is directly related to the changeset, which adds missing language translations for ore variants and other blocks in the ModLangProvider.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Lang

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@The-Code-Monkey The-Code-Monkey merged commit c218eac into 1.21 Feb 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants