Skip to content

feat: add furnace recipe#44

Merged
The-Code-Monkey merged 3 commits into1.21from
feat/add-items
Feb 15, 2026
Merged

feat: add furnace recipe#44
The-Code-Monkey merged 3 commits into1.21from
feat/add-items

Conversation

@The-Code-Monkey
Copy link
Contributor

@The-Code-Monkey The-Code-Monkey commented Feb 15, 2026

Summary by CodeRabbit

  • New Features

    • Furnace Workbench Tier 1 is craftable from basic materials.
    • Armorers Workbench is craftable and available as a new workbench recipe.
    • Copper ore can be processed into copper ingots via Furnace T1.
    • Wood chest is craftable from logs.
    • Campfire cooking for porkchop → cooked porkchop retained.
  • Documentation

    • Recipe categories and unlock conditions clarified and reorganized.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 15, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Registers several new crafting and smelting recipes in ModRecipeProvider: campfire pork, Armorers Workbench, Furnace Workbench T1, wood chest, and Furnace T1 copper ingot; updates documentation/comments and organizes recipe groups. No public API signature changes.

Changes

Cohort / File(s) Summary
Recipe provider
src/client/java/com/tcm/MineTale/datagen/ModRecipeProvider.java
Adds recipe registrations: campfire_pork_cooking, workbench_armorers_workbench, workbench_furnace_workbench_t1, workbench_wood_chest, furnace_t1_copper_ingot. Clarifies unlock conditions, categories, export names, and restructures comments into Workbenches / Chests / Ingots groups. No method signature/API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • feat: add furnace recipe #44 — Modifies the same ModRecipeProvider.java to add Workbench and Furnace T1 (copper ingot) recipe registrations; likely directly related.

Suggested labels

enhancement

Poem

Hi! I'm a rabbit with a tiny hop,
I stamp the recipes, then do a flip-flop.
Logs and copper find their place,
Workbenches hum in craftly grace. 🐇✨

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions only furnace recipe, but the PR also adds workbench recipes and organizes multiple recipe sections, making the title incomplete and partially misleading. Update the title to reflect all primary changes, such as 'feat: add furnace and workbench recipes' or 'feat: enhance recipe provider with workbench and furnace recipes'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into 1.21

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/add-items

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 15, 2026

Note

Docstrings generation - SUCCESS
Generated docstrings for this pull request at #45

Docstrings generation was requested by @The-Code-Monkey.

* #44 (comment)

The following files were modified:

* `src/client/java/com/tcm/MineTale/datagen/ModRecipeProvider.java`
…79a362

📝 Add docstrings to `feat/add-items`
@The-Code-Monkey The-Code-Monkey merged commit 0622131 into 1.21 Feb 15, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant