Skip to content

Fixed furnace models#43

Merged
The-Code-Monkey merged 1 commit into1.21from
models-and-textures
Feb 15, 2026
Merged

Fixed furnace models#43
The-Code-Monkey merged 1 commit into1.21from
models-and-textures

Conversation

@MiffenKop
Copy link
Collaborator

@MiffenKop MiffenKop commented Feb 15, 2026

reverting what the bot did to furnace_bottom.json

Summary by CodeRabbit

Release Notes

  • Visual Updates
    • Refined the furnace block model with improved geometry positioning and rotation alignment.
    • Enhanced the furnace item model with additional visual elements for better appearance.
    • Updated furnace model coordinates and orientations for improved visual consistency.

reverting what the bot did to furnace_bottom
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 15, 2026

📝 Walkthrough

Walkthrough

The PR adjusts 3D model element coordinates and rotation origins across three furnace-related JSON model files (block bottom, block top, and item models), while adding new geometric elements to refine the visual appearance of the furnace structure.

Changes

Cohort / File(s) Summary
Furnace Block Models
src/main/resources/assets/minetale/models/block/bench/furnace_bottom.json, src/main/resources/assets/minetale/models/block/bench/furnace_top.json
Shifted rotation origins along the x-axis (from -8 to 0 for top model) and adjusted element coordinates for bottom model. Added new geometric elements to both files with updated positioning and face definitions.
Furnace Item Model
src/main/resources/assets/minetale/models/item/bench/furnace.json
Added a new cuboid element with dimensions and UV mappings for improved item model geometry.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • The-Code-Monkey

Poem

🐰 A furnace takes shape with care and precision,
Coordinates shift with rabbity vision,
Rotations aligned, new edges take place,
Three JSON files now show a refined face! ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fixed furnace models' accurately reflects the main change: reverting bot-made modifications to furnace model files to restore them to a correct state.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into 1.21

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch models-and-textures

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@The-Code-Monkey The-Code-Monkey merged commit ecff9c5 into 1.21 Feb 15, 2026
3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants