feat(frontend): finish toast part remove let chatbar handle polling#211
Open
PengyuChen01 wants to merge 19 commits intomainfrom
Open
feat(frontend): finish toast part remove let chatbar handle polling#211PengyuChen01 wants to merge 19 commits intomainfrom
PengyuChen01 wants to merge 19 commits intomainfrom
Conversation
Sma1lboy
changed the title
PengyuChen01
force-pushed
the
feat-frontend-add-global-notification-when-project-finish
branch
from
76a760f to
1486346
Compare
added 18 commits
April 18, 2025 12:42
PengyuChen01
force-pushed
the
feat-frontend-add-global-notification-when-project-finish
branch
2 times, most recently
from
869ff17 to
59f86b0
Compare
ZHallen122
requested changes
Jun 16, 2025
Collaborator
ZHallen122
left a comment
ZHallen122
left a comment
There was a problem hiding this comment.
Do not include any changes that is not related in this pr
ZHallen122
requested changes
Jun 16, 2025
|
|
||
| // Call the service with the extracted buffer and mimetype | ||
| return this.projectService.updateProjectPhotoUrl( | ||
| const project1 = await this.projectService.updateProjectPhotoUrl( |
Collaborator
There was a problem hiding this comment.
Remove all test code in pr like this
| @@ -644,9 +644,8 @@ export class ProjectService { | |||
| const limit = input.size > 50 ? 50 : input.size; | |||
|
|
|||
| const whereCondition = { | |||
Collaborator
There was a problem hiding this comment.
add back photoUrl: Not(IsNull()) and is public check
| username: string, | ||
| excludeUserId?: string, | ||
| ): Promise<boolean> { | ||
| const query = this.userRepository |
Collaborator
There was a problem hiding this comment.
This looks like unuse code please remove if is really unuse
| logger.info(`[SCREENSHOT] Viewport set successfully`); | ||
|
|
||
| // Navigate to URL with increased timeout and more reliable wait condition | ||
| await page.goto(url, { |
Collaborator
There was a problem hiding this comment.
those change doesnt look correct. Please check again and confirm which is critical change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.