Add component formatting support with Table class#113
Open
chrisdedman wants to merge 5 commits into
Open
Conversation
PenguinBoi12
reviewed
Jul 9, 2026
|
|
||
| rows += f"<tr>{''.join(row_cells)}</tr>" | ||
|
|
||
| return f"""<blockquote> |
Contributor
There was a problem hiding this comment.
Do we still need the blockquote?
PenguinBoi12
reviewed
Jul 9, 2026
Contributor
There was a problem hiding this comment.
It's mostly good for me, the only thing I don't like is the html formatting. While we don't use anything else; write raw html, I think it's worth doing something like https://github.com/Code-Society-Lab/ada/blob/bc56c97b129e8c53d63cd1418f520caa0f802d21/bot/extensions/moderation/kick_extension.py#L10
You also forgot tests
| self, | ||
| content: str | None = None, | ||
| *, | ||
| component: Component | None = None, |
Contributor
There was a problem hiding this comment.
I would prefer this to be after file in the list of parameters/keep raw and notice the 2 first after the *
Same for context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new Table component for structured message rendering and support for sending component-formatted messages in Room and Context. This will improve the messaging capabilities by allowing more organized and visually appealing message formats.
Type of Change
Pre-merge Checklist
pytestmypyblack .