Added Member Class Information retrival#112
Conversation
PenguinBoi12
left a comment
There was a problem hiding this comment.
The foundation of the PR is solid, it's going to be much easier to interact with users. The code in general is clean but there's a few issues with the tests and calls.
Some of those methods are doing request to matrix, like get_displayname, get_profile, etc, but there's not response validation, so if an error happens it's just going to explode. There's a helper in api called matrix_call that helps with that.
There's cases, like profile, where it might change the behaviour, if you still want to return a default value, although maybe it's better to raise (idk), you can try/catch it.
Additionally, your tests don't seem to have those possible failure covered.
PenguinBoi12
left a comment
There was a problem hiding this comment.
Almost there, a few minor thing to update and it's good to go.
…nd improve test cases for profile and permission checks
PenguinBoi12
left a comment
There was a problem hiding this comment.
Actually, I realized that most matrix_call you made are not checking the validity correctly.
… detailed presence information
…ponse handling and clarity
Description
Add a command to retrieve member information and a new Member class to manage member-related functionalities.
close #102
Type of Change
Pre-merge Checklist
pytestmypyblack .