forked from Code-4-Community/scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 0
[SSF-134]: Update FM Management Frontend #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dburkhart07
wants to merge
22
commits into
main
Choose a base branch
from
ddb/SSF-134-update-fm-management-frontend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,120
−92
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
320902d
Added in recurring donations
dburkhart07 ed330ef
prettier
dburkhart07 16daa0f
Final commit
dburkhart07 0484af8
Final commit
dburkhart07 d6f6acf
Final commit
dburkhart07 ffea078
Final commit fr this time
dburkhart07 90cbe4a
Fixed donation enum names
dburkhart07 ead7228
Merged main and made changes
dburkhart07 17a5fc5
prettier
dburkhart07 d634048
Review comments
dburkhart07 b60bc35
Final commit
dburkhart07 635b89b
Final commit fr this time
dburkhart07 fd9bb33
prettier
dburkhart07 1add714
Some more review comments
dburkhart07 e663e18
More comments
dburkhart07 077d928
More changes!!
dburkhart07 c94c88a
Added in main yarn configurations
dburkhart07 937192c
Final commit
dburkhart07 0e6b95b
prettier
dburkhart07 840973c
Fixed selected days text logic
dburkhart07 0e7c727
prettier
dburkhart07 baff8bb
merged main
dburkhart07 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import { | ||
| ArrayNotEmpty, | ||
| IsArray, | ||
| IsDate, | ||
| IsEnum, | ||
| IsNotEmpty, | ||
| IsNumber, | ||
| IsOptional, | ||
| Min, | ||
| ValidateIf, | ||
| } from 'class-validator'; | ||
| import { DonationStatus, RecurrenceEnum } from '../types'; | ||
| import { Type } from 'class-transformer'; | ||
|
|
||
| export class CreateDonationDto { | ||
| @IsNumber() | ||
| @Min(1) | ||
| foodManufacturerId!: number; | ||
|
|
||
| @IsNumber() | ||
| @Min(1) | ||
| @IsOptional() | ||
| totalItems?: number; | ||
|
|
||
| @IsNumber({ maxDecimalPlaces: 2 }) | ||
| @Min(0.01) | ||
| @IsOptional() | ||
| totalOz?: number; | ||
|
|
||
| @IsNumber({ maxDecimalPlaces: 2 }) | ||
| @Min(0.01) | ||
| @IsOptional() | ||
| totalEstimatedValue?: number; | ||
|
|
||
| @IsNotEmpty() | ||
| @IsEnum(RecurrenceEnum) | ||
| recurrence!: RecurrenceEnum; | ||
|
|
||
| @IsNumber() | ||
| @ValidateIf((o) => o.recurrence !== RecurrenceEnum.NONE) | ||
| @Min(1) | ||
| recurrenceFreq?: number; | ||
|
|
||
| @Type(() => Date) | ||
| @IsArray() | ||
| @ArrayNotEmpty() | ||
| @IsDate({ each: true }) | ||
| @ValidateIf((o) => o.recurrence !== RecurrenceEnum.NONE) | ||
| nextDonationDates?: Date[]; | ||
|
|
||
| @IsNumber() | ||
| @ValidateIf((o) => o.recurrence !== RecurrenceEnum.NONE) | ||
| @Min(1) | ||
| occurrencesRemaining?: number; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
apps/backend/src/migrations/1770080947285-AddDonationRecurrenceFields.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import { MigrationInterface, QueryRunner } from 'typeorm'; | ||
|
|
||
| export class AddDonationRecurrenceFields1770080947285 | ||
| implements MigrationInterface | ||
| { | ||
| public async up(queryRunner: QueryRunner): Promise<void> { | ||
| await queryRunner.query(` | ||
| CREATE TYPE donation_recurrence_enum AS ENUM ( | ||
| 'none', | ||
| 'weekly', | ||
| 'monthly', | ||
| 'yearly' | ||
| ); | ||
| `); | ||
|
|
||
| await queryRunner.query(` | ||
| ALTER TABLE donations | ||
| ADD COLUMN recurrence donation_recurrence_enum NOT NULL DEFAULT 'none', | ||
| ADD COLUMN recurrence_freq INTEGER, | ||
| ADD COLUMN next_donation_dates TIMESTAMP WITH TIME ZONE[], | ||
| ADD COLUMN occurrences_remaining INTEGER; | ||
| `); | ||
|
|
||
| await queryRunner.query(` | ||
| ALTER TABLE donations | ||
| ADD CONSTRAINT recurrence_fields_not_null CHECK ( | ||
| (recurrence = 'none' | ||
| AND recurrence_freq IS NULL | ||
| AND next_donation_dates IS NULL | ||
| AND occurrences_remaining IS NULL) | ||
| OR | ||
| (recurrence != 'none' | ||
| AND recurrence_freq IS NOT NULL | ||
| AND next_donation_dates IS NOT NULL | ||
| AND occurrences_remaining IS NOT NULL) | ||
| ); | ||
| `); | ||
| } | ||
|
|
||
| public async down(queryRunner: QueryRunner): Promise<void> { | ||
| await queryRunner.query(` | ||
| ALTER TABLE donations | ||
| DROP CONSTRAINT recurrence_fields_not_null, | ||
| DROP COLUMN recurrence, | ||
| DROP COLUMN recurrence_freq, | ||
| DROP COLUMN next_donation_dates, | ||
| DROP COLUMN occurrences_remaining; | ||
| DROP TYPE donation_recurrence_enum; | ||
| `); | ||
| } | ||
| } |
19 changes: 19 additions & 0 deletions
19
apps/backend/src/migrations/1770679339809-AddFoodRescueToDonationItems.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { MigrationInterface, QueryRunner } from 'typeorm'; | ||
|
|
||
| export class AddFoodRescueToDonationItems1770679339809 | ||
| implements MigrationInterface | ||
| { | ||
| public async up(queryRunner: QueryRunner): Promise<void> { | ||
| await queryRunner.query(` | ||
| ALTER TABLE donation_items | ||
| ADD COLUMN food_rescue boolean NOT NULL DEFAULT false | ||
| `); | ||
| } | ||
|
|
||
| public async down(queryRunner: QueryRunner): Promise<void> { | ||
| await queryRunner.query(` | ||
| ALTER TABLE donation_items | ||
| DROP COLUMN food_rescue | ||
| `); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE FOR PR Reviewer: We deleted this since it does not make sense to have either of these fields here in creating a donation. The status will always be the same, as will the date donated.