[SSF-137] Orders Service and Controller Tests #102
+580
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dburkhart07
reviewed
Feb 10, 2026
| expect(result.orderId).toBe(1); | ||
| }); | ||
|
|
||
| it('throws BadRequestException for non positive ID', async () => { |
There was a problem hiding this comment.
Tests like these are something I think we should determine if we want to do now, before we start doing the rest of our testing. @sam-schu this test is honestly just making sure the validate call works. Is it really worth testing this helper function that is called in almost all of our service functions, or can we test it separately and not have to do this every single time for every single test? I'm more in favor of the second option.
Member
Author
There was a problem hiding this comment.
yeah we actually already test them in validation.utils.spec.ts so imma delete
amywng
force-pushed
the
acw/SSF-137-orders-tests
branch
from
8629389 to
1a806ca
Compare
…to foodManufacturerId, fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes SSF-137
📝 Description
findOrderPantrybecause FK constraint guarantees valid pantry reference.✔️ Verification
Ran yarn test with all tests passing.
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!