-
Notifications
You must be signed in to change notification settings - Fork 0
fixing frontend breaks from SSF-114 #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dburkhart07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a bit out of scope for this ticket, but could we rearrange the table to match the Figma design: https://www.figma.com/design/brc5luMhizIFp893XIutYe/SP26---SSF-Designs?node-id=1891-50144&m=dev
Not sure how this happened, but I guess either the design changed, or the person who implemented it originally messed up the order on the table (let's go with the first one though).
dburkhart07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😸
|
@dburkhart07 @amywng Swar has a ticket to update the admin order management frontend based on design updates so further updates there are not necessary as part of this, thanks! |
dburkhart07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🎊 🫘 🏯
ℹ️ Issue
📝 Description
#90 broke the admin-order-management page so I fixed the entity and also removed/fixed some misc. items, such as role on the pantry info (role will always be pantry) and switching the date types in the frontend
types.tsto strings because the dates from the API come back serialized as strings.✔️ Verification
Smoke tested all pages.
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!