Endpoint to retrieve applications by discipline #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hp adding migrations - test
adding comments to explain type error
Create application entity
[Issue #16] - create discipline entity in TypeORM
…le and application types
added testing removed deprecated on update adding user authentication by adding provider deleted old migration file and used just the main one
Renames the learner entity to Applicant and replaces id with appId as the identifier
…-pt-35-incorporating-client-feedback-on-which-fields-are-mutually-exclusive
turns off nx cloud
(new) backend refactor pt 2
…into delete-learner-route
…vice to be applicant
Delete learner route
Updated README to reflect new application name and setup instructions.
Formatted commands in the README for better readability.
Updated instructions for installing nx globally.
Updated README to include setup instructions for local development and database configuration.
Updated PostgreSQL installation instructions for Windows and MacOS.
Adds local development setup instructions as readme
Replace test email endpoint with a generic one
SamNie2027
deleted the
endpoint-to-retrieve-applications-by-discipline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes <152>
📝 Description
Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.
Briefly list the changes made to the code:
added an endpoint to retrieve applications by discipline
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
i thoroughly tested from the controller and service level.
Provide screenshots of any new components, styling changes, or pages.
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!