128 refactoring part 6 #114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hp adding migrations - test
adding comments to explain type error
Create application entity
[Issue #16] - create discipline entity in TypeORM
…le and application types
added testing removed deprecated on update adding user authentication by adding provider deleted old migration file and used just the main one
Renames the learner entity to Applicant and replaces id with appId as the identifier
…-pt-35-incorporating-client-feedback-on-which-fields-are-mutually-exclusive
turns off nx cloud
(new) backend refactor pt 2
…into delete-learner-route
…vice to be applicant
Delete learner route
Updated README to reflect new application name and setup instructions.
Formatted commands in the README for better readability.
Updated instructions for installing nx globally.
Updated README to include setup instructions for local development and database configuration.
Updated PostgreSQL installation instructions for Windows and MacOS.
Adds local development setup instructions as readme
Replace test email endpoint with a generic one
Author
|
omg wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #128
📝 Description
Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.
I added migrations to create the learner-info and volunteer-info tables. These tables both held the primary key appId and either the School enum or license varchar fields. I then imported the learner-info and volunteer-info entities into the data-source.ts file so they could be used in the migration
Briefly list the changes made to the code:
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
\dt BEFORE Migration
\dt AFTER Migration
Postman Tests
Volunteer info successful POST request
Volunteer POST request error handling
Learner info successful POST request
Learner info POST request error handling
Details of tables
Seed info inside tables
Running the command in down() in the migration undos the creations of the tables, \dt output:
🏕️ (Optional) Future Work / Notes
In order to run the Postman tests, I had to import the learner info and volunteer info controllers, services, and entities into the app.module.ts file. I researched online which said we may want to put the individual controllers and services into the applications.module.ts (as opposed to the app.module.ts file) to make it cleaner. I decided to not push this specific change since I felt like it is out of scope for the ticket, but can push if required.
I did not push the seed file changes but do trust I made them to test out the usability of the migrated-in newly created tables.
