-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/image carousel #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
aaronashby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 💯
thaninbew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Super duper cool!!
Feedback:
Is it possible to overlap the cards to more closely match the Figma design?
Another thing is, on my end I don't see animations. The 7second rotation works great, but I don't see any movement or transitional period, just instantly snaps to the next orientation.
I see the transition logic, but I believe the cause may be that the Card component is defined inside the main carousel component (Line 72 AutoRotatingTestimonialCarousel.tsx), in React this causes the object to deleted and recreated. That's kind of my understanding and I think it has to do with the DOM and since the type of component changes it recreates it rather than updates only the props to allow animation. Lmk if that makes any sense..
Animation logic looks solid, can't wait to see this fully working!!
|
hey! still don't see the animations on my side. is it working on yours? component looks good though. |


Description
This PR implements the testimonial carousel component. The carousel is built using React, Tailwind CSS, and shadcn UI primitives, and matches the Figma hi-fi design. It supports dynamic slide data, animated transitions, and responsive layouts across screen sizes.
Changes Made
[x ] Frontend changes
[x ] Configuration updates
Implemented a reusable AutoRotatingTestimonialCarousel component
Implemented left/right navigation arrows with disabled state during animation
Testing & Verification
Screenshots (if relevant)
Related Issues
Closes #47