#43 - Create endpoint for sending emails #54

piersolh · 2026-01-25T17:21:16Z

Description

Briefly describe the changes and why they are needed.

Enable FCC to send emails to donors

Changes Made

Testing & Verification

Unit tests pass
Manual testing completed

IMPORTANT!!!

No breaking changes - 🚨 code will break if you don't add your AWS key to the docker-compose.dev.yml 🚨

Verification Steps:

Wrote unit tests
Tested by sending a few emails to myself

Unit tests passed
Emails were sent and received by me

Screenshots (if relevant)

Future Improvements/Notes

Move key management to team wide secrets manager (followup ticket: Migrate Env Variables to AWS Secrets Manager #57)
Add email templates (recurring donor email template, thank you email template, etc)

Related Issues

Closes #43

…vices dependency issue is fixed

piersolh · 2026-02-08T14:59:24Z

apps/backend/src/emails/amazon-ses-client.factory.ts

+import { SES as AmazonSESClient } from '@aws-sdk/client-ses';
+import { strict as assert } from 'node:assert';
+import * as dotenv from 'dotenv';
+import path from 'node:path';


I struggled getting the docker to recognize the env variables, might not be necessary once we move to secrets manager?

piersolh · 2026-02-08T15:01:20Z

apps/backend/src/emails/amazon-ses-client.factory.ts

+import path from 'node:path';
+dotenv.config({ path: path.resolve(__dirname, '.env') });
+
+export const AMAZON_SES_CLIENT = 'AMAZON_SES_CLIENT';


Had to hardcode this so that nestJS would recognize it, otherwise I got the error that ERROR [ExceptionHandler] Nest can't resolve dependencies of the EmailsService (?).

piersolh · 2026-02-08T15:01:44Z

apps/backend/src/emails/emails.controller.ts

+  constructor(private readonly emailService: EmailsService) {}
+
+  @Post('send-email')
+  // @UseGuards(JwtAuthGuard) (should use auth, not implemented rn)


commented out for now, should be uncommented once auth is added to the project for security

piersolh · 2026-02-08T15:07:01Z

apps/backend/src/emails/emails.service.spec.ts

@@ -0,0 +1,116 @@
+import { Test, TestingModule } from '@nestjs/testing';


is this sufficient testing? I am still new to backend

ok for now!

piersolh · 2026-02-08T15:07:34Z

apps/backend/src/payments/payments.module.ts

      useFactory: (configService: ConfigService) => {
        return new Stripe(configService.get<string>('STRIPE_SECRET_KEY'), {
-          apiVersion: '2025-09-30.clover',
+          apiVersion: '2025-12-15.clover',


I keep having an issue with this file reverting / changing versions when I load my docker containers. I am not sure why this is happening.

I will look into this.

piersolh · 2026-02-08T15:08:05Z

apps/frontend/src/components/ui/button.tsx

@@ -50,7 +50,6 @@ function Button({
  }) {
  const Comp = asChild ? Slot : 'button';


Did not modify, this is from merging my PR with main to avoid merge conflicts

we can leave that there actuallyy

piersolh · 2026-02-08T15:08:47Z

docker-compose.dev.yml

      JWT_SECRET: dev-secret-change-in-prod
-
+      AWS_SES_REGION: us-east-2
+      AWS_SES_ACCESS_KEY_ID: 


docker compose must be modified for the code to compile, AWS key + AWS sender email is necessary.

piersolh · 2026-02-08T15:08:59Z

package.json

  "private": true,
  "dependencies": {
    "@aws-sdk/client-cognito-identity-provider": "^3.410.0",
+    "@aws-sdk/client-ses": "^3.975.0",


had to add ses to the project

piersolh · 2026-02-08T15:09:23Z

yarn.lock

@@ -2,1328 +2,1346 @@
 # yarn lockfile v1




added ses to the proejct

thaninbew · 2026-02-10T05:17:17Z

apps/frontend/src/components/ui/button.tsx

@@ -50,7 +50,6 @@ function Button({
  }) {
  const Comp = asChild ? Slot : 'button';


we can leave that there actuallyy

thaninbew · 2026-02-10T05:18:47Z

apps/backend/src/emails/emails.service.spec.ts

@@ -0,0 +1,116 @@
+import { Test, TestingModule } from '@nestjs/testing';


ok for now!

added some intial scaffolding, not compiling for some reason

79a93f6

piersolh linked an issue Jan 25, 2026 that may be closed by this pull request

Create Endpoint for Sending Emails #43

Open

piersolh added 4 commits January 27, 2026 08:17

merge w main

e967e95

changing the emails module to see if the nestJS cannot read email ser…

bc3e0d7

…vices dependency issue is fixed

fixing tests + fixed auth errors

776993e

modify docker compose file so the SES will work

87f6385

piersolh changed the title ~~added some intial scaffolding, not compiling for some reason~~ #43 - Create endpoint for sending emails Feb 8, 2026

piersolh commented Feb 8, 2026

View reviewed changes

piersolh added 2 commits February 8, 2026 10:03

remove unecessary comments

aa2ddda

remove unecessary comment

d6c65ec

piersolh commented Feb 8, 2026

View reviewed changes

yarn.lock

@@ -2,1328 +2,1346 @@

# yarn lockfile v1

Copy link

Author

piersolh Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added ses to the proejct

piersolh marked this pull request as ready for review February 8, 2026 15:12

merge w main

dd6f65d

aaronashby requested review from aaronashby and thaninbew February 9, 2026 07:57

thaninbew requested changes Feb 10, 2026

View reviewed changes

		@@ -0,0 +1,116 @@
		import { Test, TestingModule } from '@nestjs/testing';

		@@ -50,7 +50,6 @@ function Button({
		}) {
		const Comp = asChild ? Slot : 'button';

#43 - Create endpoint for sending emails #54

Are you sure you want to change the base?

#43 - Create endpoint for sending emails #54

Conversation

piersolh commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes Made

Testing & Verification

IMPORTANT!!!

Screenshots (if relevant)

Future Improvements/Notes

Related Issues

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

piersolh commented Jan 25, 2026 •

edited

Loading