109 Login / Logout / Verify / Resend-code endpoints #114
+395
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniwang
changed the title
denniwang
force-pushed
the
109-login-endpoint
branch
from
1171d61 to
7ae7418
Compare
denniwang
changed the title
denniwang
force-pushed
the
109-login-endpoint
branch
from
240c3d3 to
d6fc722
Compare
nourshoreibah
approved these changes
Feb 8, 2026
Collaborator
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
thank you so much for going the extra mile with the verify and 2fa code endpoints. LGTM!
Contributor
Author
|
Dear @nourshoreibah, 👀 -xoxo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #109
📝 Description
enabled essential auth points
Added endpoints for
✔️ Verification
used bruno / postman to test out the endpoints, discovered verification code times out after 15 min or so?
🏕️ (Optional) Future Work / Notes
code email is a lil ugly but acceptable.
maybe need to do some pw encryption in the requests somewhere
try not to scope creep challenge level impossible