feat: use instrument-hook markers in walltime#118
Merged
Conversation
Merging this PR will degrade performance by 42.77%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | test_multiprocessing_map[10000] |
101.1 ms | 89.4 ms | +13.1% |
| ⚡ | WallTime | test_pipe_communication[10000] |
14.5 ms | 12.8 ms | +13.42% |
| 👁 | WallTime | test_make_peak |
6.3 µs | 6.6 µs | -4.51% |
| ⚡ | WallTime | test_sudoku[initial_grid0] |
7.9 µs | 7.8 µs | +2.07% |
| ⚡ | WallTime | test_process_creation[cat /dev/null] |
5.4 ms | 5.2 ms | +2.34% |
| 👁 | WallTime | test_threadpool_map[10] |
2.3 ms | 2.4 ms | -3.15% |
| ⚡ | WallTime | test_threadpool_map[10000] |
386.6 ms | 378.1 ms | +2.24% |
| ⚡ | WallTime | test_combination_sum[candidates0-8] |
11.5 µs | 11.2 µs | +2.8% |
| ⚡ | WallTime | test_n_queens_solve[board0] |
11.1 ms | 10.8 ms | +2.26% |
| 👁 | WallTime | test_recursive_fibo_20 |
5.5 ms | 5.9 ms | -5.85% |
| 👁 | WallTime | test_multiprocessing_map[1000] |
56.9 ms | 59.3 ms | -4.02% |
| ⚡ | WallTime | test_sum_squares_fast |
162.5 µs | 157 µs | +3.53% |
| ⚡ | WallTime | test_sum_of_squares[sum_of_squares_sum_labmda_power] |
364.4 µs | 314.1 µs | +16.03% |
| 👁 | WallTime | test_hostname_resolution[8.8.8.8] |
8 µs | 8.3 µs | -2.88% |
| ⚡ | WallTime | test_tcp_connection[1.1.1.1-53] |
1.1 ms | 1 ms | +6.97% |
| 👁 | WallTime | test_fs_write[1000] |
17.7 µs | 18.3 µs | -3.14% |
| 👁 | WallTime | test_pipe_communication[1000] |
6.4 ms | 6.6 ms | -3.12% |
| 👁 | WallTime | test_mmap_operation[409600] |
134.9 µs | 137.7 µs | -2.01% |
| ⚡ | WallTime | test_multiprocessing_map[100] |
60.4 ms | 53 ms | +13.92% |
| ⚡ | WallTime | test_noop_pass |
535.6 ns | 483.1 ns | +10.85% |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing use-benchmark-start-end-markers (befdebf) with master (fda1fbc)
GuillaumeLagrange
force-pushed
the
use-benchmark-start-end-markers
branch
from
754fb43 to
ae47707
Compare
not-matthias
approved these changes
May 7, 2026
Member
not-matthias
left a comment
not-matthias
left a comment
There was a problem hiding this comment.
LGTM overall, but we shouldn't modify the time computation.
GuillaumeLagrange
force-pushed
the
use-benchmark-start-end-markers
branch
6 times, most recently
from
f587d0c to
b44c4d2
Compare
art049
requested changes
May 13, 2026
GuillaumeLagrange
force-pushed
the
use-benchmark-start-end-markers
branch
from
b44c4d2 to
ffb73a3
Compare
Transpiled code generates these.
GuillaumeLagrange
force-pushed
the
use-benchmark-start-end-markers
branch
from
ffb73a3 to
befdebf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.