Skip to content

fix(skills): misleading DCE advice in setup-harness #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SuperMuel wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −2
Open

fix(skills): misleading DCE advice in setup-harness #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67f8293
fix(skills): misleading DCE advice in setup-harness
SuperMuel May 14, 2026
74f7800
fix(skills): drop trailing whitespace
SuperMuel May 14, 2026
533a7ca
Merge remote-tracking branch 'origin/main' into fix/skill-pedantic-no…
SuperMuel May 15, 2026
d395403
fix(ci): restore toolchain auto-install on macOS lint
SuperMuel May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/install-rust/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ runs:
steps:
- name: Install rust-toolchain.toml
shell: bash
run: rustup show
run: rustup toolchain install
- name: Install additional rustup components
if: inputs.components != ''
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion skills/codspeed-setup-harness/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ Good benchmarks are representative, isolated, and stable. Here are guidelines:

- **Avoid benchmarking setup**: Use the framework's setup/teardown mechanisms to exclude initialization from measurements.

- **Prevent dead code elimination**: Use `black_box()` (Rust), `benchmark.pedantic()` (Python), or equivalent to ensure the compiler/runtime doesn't optimize away the work you're measuring.
- **Prevent dead code elimination**: Use `black_box()` (Rust), `benchmark::DoNotOptimize` (C++), or `Blackhole.consume` (JMH) so the compiler doesn't optimize away unused results.

- **Cover the critical path**: Benchmark the functions that matter most to your users — the ones called frequently or on the hot path.

Expand Down