Skip to content

fix: skip warmup for embedded benchmarks #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
not-matthias merged 1 commit into from
Apr 28, 2026
Merged

fix: skip warmup for embedded benchmarks #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions jmh-fork/jmh-core/src/main/java/org/openjdk/jmh/runner/BaseRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,16 +148,17 @@ public void acceptMeta(BenchmarkResultMetaData md) {
}

private void doSingle(BenchmarkParams params, ActionMode mode, IterationResultAcceptor acceptor) {
boolean isWarmup = !mode.doMeasurement() || isWarmupFork();
try {
switch (mode) {
case WARMUP: {
runBenchmark(params, null);
runBenchmark(params, null, isWarmup);
out.println("");
break;
}
case WARMUP_MEASUREMENT:
case MEASUREMENT: {
runBenchmark(params, acceptor);
runBenchmark(params, acceptor, isWarmup);
break;
}
default:
Expand Down Expand Up @@ -248,11 +249,11 @@ private String formatDuration(long nanos) {
return String.format("%s%02d:%02d:%02d", (days > 0) ? days + " days, " : "", hrs, mins, secs);
}

void runBenchmark(BenchmarkParams benchParams, IterationResultAcceptor acceptor) {
void runBenchmark(BenchmarkParams benchParams, IterationResultAcceptor acceptor, boolean isWarmup) {
BenchmarkHandler handler = null;
try {
handler = new BenchmarkHandler(out, options, benchParams);
runBenchmark(benchParams, handler, acceptor);
runBenchmark(benchParams, handler, acceptor, isWarmup);
} catch (BenchmarkException be) {
throw be;
} catch (Throwable ex) {
Expand All @@ -264,7 +265,7 @@ void runBenchmark(BenchmarkParams benchParams, IterationResultAcceptor acceptor)
}
}

protected void runBenchmark(BenchmarkParams benchParams, BenchmarkHandler handler, IterationResultAcceptor acceptor) {
protected void runBenchmark(BenchmarkParams benchParams, BenchmarkHandler handler, IterationResultAcceptor acceptor, boolean isWarmup) {
long warmupTime = System.currentTimeMillis();

long allWarmup = 0;
Expand Down Expand Up @@ -307,7 +308,7 @@ protected void runBenchmark(BenchmarkParams benchParams, BenchmarkHandler handle
IterationResult ir = handler.runIteration(benchParams, mp, isFirstIteration, isLastIteration);
long endTs = InstrumentHooks.currentTimestamp();

if (!isWarmupFork()) {
if (!isWarmup) {
InstrumentHooks hooks = InstrumentHooks.getInstance();
int pid = (int) ProcessHandle.current().pid();
hooks.addMarker(pid, InstrumentHooks.MARKER_TYPE_BENCHMARK_START, startTs);
Expand Down
Loading