Skip to content

fix duplicate compute dependencies#158

Open
jseanj wants to merge 1 commit into
CocoaPods:masterfrom
jseanj:master
Open

fix duplicate compute dependencies#158
jseanj wants to merge 1 commit into
CocoaPods:masterfrom
jseanj:master

Conversation

@jseanj

@jseanj jseanj commented Sep 24, 2021

Copy link
Copy Markdown

possibility_set has included all dependencies, so there is no need to duplicate compute dependencies.

@dnkoutso

Copy link
Copy Markdown
Contributor

hi there, what issue does this fix and can you add a test? or is it a performance improvement?

@jseanj

jseanj commented Sep 24, 2021

Copy link
Copy Markdown
Author

hi there, what issue does this fix and can you add a test? or is it a performance improvement?

The issue is possibility_set has cached the dependencies for possibility, so no need to re-acquire the dependencies.

I think it's a performance improvement that is not obvious, because the podspec usually doesn't have a lot of dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants