Fix flake not accepting keyFile option#47
Merged
Conversation
Contributor
Author
|
@yyasha Let me know what you think. Nix is not my specialty, so feedback is welcome. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the NixOS module in flake.nix so services.wg-obfuscator.instances.<name>.keyFile can be used without having to set key, addressing issue #46 where module evaluation/build still required key.
Changes:
- Make the per-instance
keyoption nullable with anulldefault, enabling configs that rely solely onkeyFile. - Update the module assertion to accept
key = nullwhenkeyFileis provided. - Fix config generation to pass the enabled-instances attrset (not a list) to
mapAttrsToList.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
I have been using this without issue for a while btw. |
Owner
|
Merged, thank you! |
Contributor
Author
|
Sure thing, thanks for the merge 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46
Had to fix a couple of minor things. Note that this does not allow using a keyFile under ~, because the systemd unit that runs the generated script has protectHome enabled. But it works well for keyfiles that are under /run/secrets, etc.