Skip to content

Refactor TUI profile modal state#228

Merged
rmanibus merged 1 commit into
mainfrom
refactor/tui-profile-modal-state
Apr 3, 2026
Merged

Refactor TUI profile modal state#228
rmanibus merged 1 commit into
mainfrom
refactor/tui-profile-modal-state

Conversation

@rmanibus
Copy link
Copy Markdown
Contributor

@rmanibus rmanibus commented Apr 3, 2026

Summary

  • extract source-specific profile modal behavior into a dedicated helper type
  • replace string-encoded modal field errors with a typed validation error
  • make modal view generation side-effect free and add focused tests

Verification

  • env GOCACHE=/tmp/cloudstic-gocache go test -count=1 ./cmd/cloudstic ./internal/tui ./internal/app
  • env GOCACHE=/tmp/cloudstic-gocache GOLANGCI_LINT_CACHE=/tmp/cloudstic-golangci-lint golangci-lint run ./cmd/cloudstic ./internal/tui ./internal/app

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 58.20896% with 56 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/cloudstic/cmd_tui_profile_source.go 53.62% 31 Missing and 1 partial ⚠️
cmd/cloudstic/cmd_tui_profile_form.go 63.07% 22 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@rmanibus rmanibus merged commit 3425155 into main Apr 3, 2026
10 of 11 checks passed
@rmanibus rmanibus deleted the refactor/tui-profile-modal-state branch April 3, 2026 20:53
@rmanibus rmanibus added this to the v1.15.0 milestone Apr 3, 2026
@rmanibus rmanibus added chore Maintenance and tooling changes refactor area/tui Interactive terminal UI work and removed chore Maintenance and tooling changes labels Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tui Interactive terminal UI work refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant