Update 99999980-upgrade-python-on-linux.md#194
Update 99999980-upgrade-python-on-linux.md#194wyatt-wong wants to merge 1 commit intoCloudBytes-Academy:mainfrom
Conversation
Reviewer's Guide by SourceryThis PR updates the Linux Python upgrade guide by enhancing the virtual environment creation instructions and automating the shell configuration reload process for oh-my-zsh users. The changes provide users with an alternative method for setting up a virtual environment using sudo and ensure that alias changes are applied immediately. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @wyatt-wong - I've reviewed your changes - here's some feedback:
Overall Comments:
- It's good to see specific examples, but be careful about including
sudoin them as it might not always be necessary or desired.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| E.g. you can create a new virtual environment by running | ||
|
|
||
| ```bash | ||
| sudo python3.13 -m venv venv |
There was a problem hiding this comment.
issue (bug_risk): Redundant and potentially incorrect use of sudo with venv
The added line seems redundant as it's very similar to the following line. Using sudo with venv is generally discouraged and can lead to permission issues. If the intention was to show two different ways to create a virtual environment, please clarify the purpose of using sudo in this case. Otherwise, consider removing the line.
| ```bash | ||
| echo "alias py=/usr/bin/python3" >> ~/.zshrc | ||
| echo "alias python=/usr/bin/python3" >> ~/.zshrc | ||
| omz reload |
There was a problem hiding this comment.
suggestion: Clarify terminal restart instruction
While restarting the terminal guarantees the changes are applied, sourcing the .zshrc file should be sufficient. Consider rephrasing the instruction to something like: "After restarting your terminal or sourcing your .zshrc file."
Summary by Sourcery
Update instructions for creating a virtual environment and reloading oh-my-zsh.
Enhancements:
sudowhen creating virtual environments usingpython3.13 -m venv venv.omz reloadto the instructions for updating the Python alias in oh-my-zsh.