Skip to content

Update 99999980-upgrade-python-on-linux.md#194

Open
wyatt-wong wants to merge 1 commit intoCloudBytes-Academy:mainfrom
wyatt-wong:patch-1
Open

Update 99999980-upgrade-python-on-linux.md#194
wyatt-wong wants to merge 1 commit intoCloudBytes-Academy:mainfrom
wyatt-wong:patch-1

Conversation

@wyatt-wong
Copy link

@wyatt-wong wyatt-wong commented Feb 10, 2025

Summary by Sourcery

Update instructions for creating a virtual environment and reloading oh-my-zsh.

Enhancements:

  • Add sudo when creating virtual environments using python3.13 -m venv venv.
  • Add omz reload to the instructions for updating the Python alias in oh-my-zsh.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 10, 2025

Reviewer's Guide by Sourcery

This PR updates the Linux Python upgrade guide by enhancing the virtual environment creation instructions and automating the shell configuration reload process for oh-my-zsh users. The changes provide users with an alternative method for setting up a virtual environment using sudo and ensure that alias changes are applied immediately.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Enhanced virtual environment creation instructions
  • Added a command using 'sudo python3.13 -m venv venv' as an alternative for creating a virtual environment
content/articles/99999980-upgrade-python-on-linux.md
Automated oh-my-zsh configuration reload
  • Inserted 'omz reload' to reload shell configuration after alias entries are added
content/articles/99999980-upgrade-python-on-linux.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wyatt-wong - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It's good to see specific examples, but be careful about including sudo in them as it might not always be necessary or desired.
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

E.g. you can create a new virtual environment by running

```bash
sudo python3.13 -m venv venv
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Redundant and potentially incorrect use of sudo with venv

The added line seems redundant as it's very similar to the following line. Using sudo with venv is generally discouraged and can lead to permission issues. If the intention was to show two different ways to create a virtual environment, please clarify the purpose of using sudo in this case. Otherwise, consider removing the line.

```bash
echo "alias py=/usr/bin/python3" >> ~/.zshrc
echo "alias python=/usr/bin/python3" >> ~/.zshrc
omz reload
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Clarify terminal restart instruction

While restarting the terminal guarantees the changes are applied, sourcing the .zshrc file should be sufficient. Consider rephrasing the instruction to something like: "After restarting your terminal or sourcing your .zshrc file."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant