imagebuilder: introduce Variant field for per-pin image directories#283
Open
Vikramarjuna wants to merge 2 commits into
Open
imagebuilder: introduce Variant field for per-pin image directories#283Vikramarjuna wants to merge 2 commits into
Vikramarjuna wants to merge 2 commits into
Conversation
rgooch
reviewed
Jul 5, 2026
rgooch
left a comment
rgooch
left a comment
Member
There was a problem hiding this comment.
What problem does this solve that can't already be achieved by adding the right combination of SourceImageGitCommitId, SourceImageBuildVariables and SourceImageTagsToMatch to manifest files?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional Variant expression to bootstrap stream configs and image manifests. When non-empty, the expanded value becomes a path segment between the stream name and the timestamp: //
Two builds of the same stream with different Variables values land in separate imageserver directories, so a lookup for one pin cannot silently match an image built under a different pin.
Backwards-compatible: when Variant is empty or absent, the traditional flat layout is used.