Added gRPC authentication and authorization infrastructure#226
Open
Vikramarjuna wants to merge 2 commits into
Open
Added gRPC authentication and authorization infrastructure#226Vikramarjuna wants to merge 2 commits into
Vikramarjuna wants to merge 2 commits into
Conversation
rgooch
requested changes
Jul 4, 2026
| return true | ||
| } | ||
|
|
||
| func authorizeRequest(ctx context.Context, fullMethod string) (context.Context, error) { |
Member
There was a problem hiding this comment.
Please use British/Australian spelling: replace z with s.
Comment applies elsewhere.
Contributor
Author
There was a problem hiding this comment.
Addressed. Updated all the words to use British spelling.
Addresses review feedback on PR Cloud-Foundations#226.
rgooch
requested changes
Jul 5, 2026
rgooch
left a comment
rgooch
left a comment
Member
There was a problem hiding this comment.
Please resolve merge conflicts.
| func authoriseRequest(ctx context.Context, fullMethod string) (context.Context, error) { | ||
| _, isPublic := publicMethods[fullMethod] | ||
| _, isUnauthenticated := unauthenticatedMethods[fullMethod] | ||
|
|
Member
There was a problem hiding this comment.
Please follow repository convention and remove all these blank lines inside functions.
|
|
||
| // AllowMethodPowers always returns true for gRPC. SRPC supports a | ||
| // "doNotUseMethodPowers" query parameter allowing clients to opt-out of | ||
| // method powers; gRPC has no equivalent mechanism. |
Member
There was a problem hiding this comment.
Is there no way to inject metadata when establishing a gRPC connection that would allow passing this information?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add gRPC Authentication and Authorisation Infrastructure
Why
Enable gRPC support for Dominator services by sharing SRPC's existing authorisation logic.
What
Adds core gRPC auth infrastructure:
lib/grpc/api.go: Unary and streaming auth interceptors,Conntype for handlers to access auth info,ServiceOptionsfor registering public/unauthenticated methodslib/srpc/api.go:AuthConninterface (implemented by both SRPC and gRPC connections),GetDefaultGrantMethod(),GetPermittedMethods(),AllowMethodPowers()lib/srpc/server.go: ExportedGetAuth()andCheckAuthorisation()so gRPC can reuse the same 4-level authorisation hierarchygRPC method names (
/package.Service/Method) are translated to SRPC format (Service.Method) for RBAC compatibility.Metrics stubs are included - actual metrics tracking comes in a later PR.
What Follows
StreamingConninterface)