Fix experiment selection for computing ZEC#589
Open
bouweandela wants to merge 1 commit intoClimate-REF:mainfrom
Open
Fix experiment selection for computing ZEC#589bouweandela wants to merge 1 commit intoClimate-REF:mainfrom
bouweandela wants to merge 1 commit intoClimate-REF:mainfrom
Conversation
bouweandela
force-pushed
the
fix-zec-dataset-experiment
branch
from
1f14ddb to
ba9aa9c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
bouweandela
force-pushed
the
fix-zec-dataset-experiment
branch
from
ba9aa9c to
eec3610
Compare
Contributor
Author
|
Opened #590 for the unrelated failing test. |
bouweandela
commented
Mar 9, 2026
| facets={ | ||
| "branded_variable": "tas_tavg-h2m-hxy-u", | ||
| "experiment_id": experiments, | ||
| "experiment_id": "esm-flat10-zec", |
Contributor
Author
There was a problem hiding this comment.
This is the experiment for CMIP7, but the current scheme we have for mocking up CMIP7 data does not convert experiments, so this leads to an empty solve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Select the correct experiment for computing ZEC.
Documentation at https://docs.esmvaltool.org/en/latest/recipes/recipe_zec.html
Follow up to #585, closes #586.
Checklist
Please confirm that this pull request has done the following:
changelog/