Skip to content

Fetch ESMValTool recipes in advance#582

Open
bouweandela wants to merge 3 commits intoClimate-REF:mainfrom
bouweandela:fix-recipes-in-advance
Open

Fetch ESMValTool recipes in advance#582
bouweandela wants to merge 3 commits intoClimate-REF:mainfrom
bouweandela:fix-recipes-in-advance

Conversation

@bouweandela
Copy link
Contributor

@bouweandela bouweandela commented Mar 6, 2026

Description

Closes #468

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
core 93.18% <100.00%> (+0.07%) ⬆️
providers ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-ref-core/src/climate_ref_core/dataset_registry.py 100.00% <100.00%> (ø)

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bouweandela bouweandela marked this pull request as ready for review March 6, 2026 17:01
@bouweandela bouweandela requested a review from lewisjared March 6, 2026 17:02
base_url=DATASET_URL,
package="climate_ref_esmvaltool.dataset_registry",
resource="data.txt",
cache_name=f"climate_ref_esmvaltool/{_DATASETS_REGISTRY_NAME}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require redownloading the datasets. I'm not 100% happy with how we handle the various caches, but that is something for another day.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you prefer to keep everything in one folder that's also fine with me, might be easier to configure for users. We may want to use a subfolder per provider in that case, to avoid that providers accidentally overwrite each others files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code in 65f9ed9 so all caches live in subdirectories under a single climate_ref cache directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESMValTool requires access to the web to retrieve the recipes

2 participants