Add test to validate duplicate tool execution in multi-step mode (#26)#29
Merged
iskakaushik merged 1 commit intomainfrom Oct 16, 2025
Merged
Add test to validate duplicate tool execution in multi-step mode (#26)#29iskakaushik merged 1 commit intomainfrom
iskakaushik merged 1 commit intomainfrom
Conversation
iskakaushik
force-pushed
the
multistep
branch
from
cd11b2d to
000f3b9
Compare
Created integration test that demonstrates tools being executed twice when max_steps > 1. The test uses execution counters to track tool invocations and asserts that each tool call is executed exactly once. Test currently fails, showing that tools are executed both in base_provider_client.cpp and multi_step_coordinator.cpp, validating the bug reported in issue #26.
iskakaushik
force-pushed
the
multistep
branch
from
000f3b9 to
fcba5fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created integration test that demonstrates tools being executed twice when max_steps > 1. The test uses execution counters to track tool invocations and asserts that each tool call is executed exactly once.
Test currently fails, showing that tools are executed both in base_provider_client.cpp and multi_step_coordinator.cpp, validating the bug reported in issue #26.
fixes #26