Merged
Conversation
- Fix filename typo: embeddding_options.h -> embedding_options.h - Remove irrelevant text generation parameters from EmbeddingOptions - Fix duplicate Content-Type header causing API failures - Add proper includes for embedding_options.h across all headers - Clean up request builders to only include relevant embedding params - Add comprehensive unit tests (20 tests) - Add integration tests with real API (15 tests) - Add embeddings_example.cpp demonstrating full functionality - All 35 tests passing
Closed
# Conflicts: # tests/CMakeLists.txt
1 task
|
@iskakaushik Great work! This SDK now fully meets ClickHouse’s needs for using remote LLMs. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.