Added IOSXE parser for 'show wireless iot-coexistence summary'#972
Added IOSXE parser for 'show wireless iot-coexistence summary'#972madhumuraliomm wants to merge 4 commits intoCiscoTestAutomation:mainfrom
Conversation
ThomasJRyan
left a comment
ThomasJRyan
left a comment
There was a problem hiding this comment.
Overall looks good, just needs a bit of maintenance
There was a problem hiding this comment.
You no longer need to include changes to github_parser.json (and honestly I thought we had added this file to the .gitignore)
|
|
||
| from .show_wireless import ShowWirelessIotCoexistenceSummary | ||
|
|
There was a problem hiding this comment.
This is unnecessary. Our library abstraction mechanism handles importing parsers. Please remove this
| """Schema for show wireless iot-coexistence summary""" | ||
|
|
||
| schema = { | ||
| Optional('ap_list'): { |
There was a problem hiding this comment.
The top-level key in a schema shouldn't be Optional. You need at least one static key that will always be there if a match has been made
| if not line: | ||
| continue | ||
|
|
||
| # Detect separator line |
There was a problem hiding this comment.
These comments should be examples of what's being matched. It's a lot easier to debug a parser when you can quickly reference the line it's matching
| if 'ap_list' not in show_wireless_iot_coexistence_summary_dict: | ||
| show_wireless_iot_coexistence_summary_dict['ap_list'] = {} |
There was a problem hiding this comment.
Could just use setdefault here
| } | ||
| continue | ||
|
|
||
| # Try matching AP without counters |
| if 'ap_list' not in show_wireless_iot_coexistence_summary_dict: | ||
| show_wireless_iot_coexistence_summary_dict['ap_list'] = {} |
|
Thomas, I've addressed all the review comments for the PR and committed the changes. Could you please review them and let me know if any further changes are required? |
2 participants
Description
Added new parser for IOSXE command:
show wireless iot-coexistence summaryMotivation and Context
Enables automation of wireless IoT coexistence monitoring by extracting:
Impact (If any)
{}for empty output (valid empty state).Screenshots:
Checklist: