[IOS-XR] Fix show vrf all detail parser - capture all interface names#911
Open
Kani999 wants to merge 3 commits intoCiscoTestAutomation:mainfrom
Open
[IOS-XR] Fix show vrf all detail parser - capture all interface names#911Kani999 wants to merge 3 commits intoCiscoTestAutomation:mainfrom
show vrf all detail parser - capture all interface names#911Kani999 wants to merge 3 commits intoCiscoTestAutomation:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Kani999
force-pushed
the
fix_interfaces_iosxr_show_vrf_all_detail
branch
from
63f819c to
db62997
Compare
Contributor
Author
|
Hi there! 👋 Best regards, |
- Implemented a general regex pattern to capture all interface names
- Replaced the previous regex that relied on specific interface prefixes (e.g., Gi, Bun, Ten, etc.) with a more general pattern `r'^(?P<intf>[A-Za-z][-A-Za-z0-9/.:]+)$'`
- Introduced `in_interfaces_section` flag for accurate section tracking
Kani999
force-pushed
the
fix_interfaces_iosxr_show_vrf_all_detail
branch
from
db62997 to
ac9dcda
Compare
Contributor
Author
|
Hi team, This PR (#911) has been open since recently, but I'm still waiting for accept or deny decision. Any update on review? I'd appreciate your feedback! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhance interface parsing in 'show vrf all detail' parser
Implemented a general regex pattern to capture all interface names:
r'^(?P<intf>[A-Za-z][-A-Za-z0-9/.:]+)$'.in_interfaces_sectionflag for accurate section tracking:in_interfaces_section= False at the beginning of the parsing process.in_interfaces_section = Trueupon encountering the Interfaces: line.in_interfaces_section = FalseMotivation and Context
Replaced the previous regex that relied on specific interface prefixes (e.g., Gi, Bun, Ten, etc.) with a more general pattern
Checklist:
Closes #910