Open
Conversation
Update schema for ShowFacilityAlarmStatus - add syslog_string
ThomasJRyan
approved these changes
Nov 22, 2024
omehrabi
requested changes
Nov 22, 2024
Contributor
omehrabi
left a comment
There was a problem hiding this comment.
Thank you for contributing
could you please add a test as well to the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update schema for ShowFacilityAlarmStatus - add syslog_string
Description
Update src/genie/libs/parser/iosxe/show_alarms.py, update ShowFacilityAlarmStatusSchema and ShowFacilityAlarmStatus, add new regex for column format on ASR920/IOS-XE 17.06.03:
Motivation and Context
Resolves #891
Screenshots:
Output of parser on production ASR920: