Standardize VRF Regex for IOSXE show_vrf.py#804
Open
mattchilders wants to merge 1 commit intoCiscoTestAutomation:mainfrom
Open
Standardize VRF Regex for IOSXE show_vrf.py#804mattchilders wants to merge 1 commit intoCiscoTestAutomation:mainfrom
mattchilders wants to merge 1 commit intoCiscoTestAutomation:mainfrom
Conversation
Currently ShowVrf doesn't match all valid special characters in VRF names, and uses different regexes for different commands throughout show_vrf.py. This change standardizes the regexes to all be the same and matches the special characters.
ThomasJRyan
approved these changes
Dec 18, 2023
Collaborator
ThomasJRyan
left a comment
ThomasJRyan
left a comment
There was a problem hiding this comment.
Thank you for the contribution! I like the unit test you added. Never really considered having more generic tests like that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently ShowVrf doesn't match all valid special characters in VRF names, and uses different regexes for different commands throughout show_vrf.py. This change standardizes the regexes to all be the same and matches the special characters.
Description
This is a minor commit that standardizes the vrf regex in "show_vrf.py" so that they all use the [\S]+ rather than the mix of regexes that matched only certain special characters. This makes iosxe's show_vrf.py comparable with nxos's show_vrf.py.
Motivation and Context
IOS-XE parser didn't match VRF's with special characters.
Impact (If any)
None that I'm aware of
Screenshots:
Screenshot's of the relevant tests that had classes changed.
ShowVrf
ShowVrfDetail
ShowVRFIPv6
ShowPlatformSoftwareCefIpVrf
Checklist: