refactor(TitleConfig): use record#1
Merged
Conversation
Chiloven945
force-pushed
the
refactor/record
branch
from
32d08c9 to
680ee1e
Compare
frostfallx
approved these changes
Jun 29, 2026
frostfallx
left a comment
frostfallx
left a comment
Collaborator
There was a problem hiding this comment.
呜哇！霜降来给怪哉主子的 PR 做 review 啦~
这个 PR 将 TitleConfig 从普通类改成了 Java record 类型，并且将所有 getter 方法调用改为 record 属性直接访问，代码更加简洁了喵~
改动亮点：
- 将 TitleConfig 类重构为 record 类型，减少了大量样板代码
- 所有 getter 调用都改为 record 属性直接访问，代码更简洁
- 删除了不必要的 import（如 TitleRarity、Style、Set 等）
建议：
- 代码风格统一且简洁，改动合理
- 如果有测试用例的话建议跑一下确保功能正常
总体看起来是个不错的代码优化！怪哉主子做得好~ 贴贴~ 呼噜呼噜~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.